metrics_capture supports ems #19511
Merged
metrics_capture supports ems #19511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
This allows metrics_capture to support multiple targets within an ems
kbrock
force-pushed
the
cu_capture_object_ems
branch
from
776741c
to
30b7932
Compare
|
simplified the logic. no longer tries to determine whether it is passed a target or an ems |
|
Checked commit kbrock@30b7932 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
agrare
approved these changes
Nov 14, 2019
This was referenced Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows metrics_capture to support multiple targets within an ems
The signature is backwards compatible
The tests in this repo run against openstack and vmware.
vmware is the only provider that overrides
initialize()extracted from #19492