-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Move queue_capture to provider metric_capture_object #19492
Conversation
There's a lot of movement in this PR, so it's hard to see if this is just moving things around or if there are actual code changes along with the moves. Are there specific commits that help the review of this? |
1c0175a
to
0ea4676
Compare
9a68a15
to
0470e92
Compare
sigh. let me know if we want to handle these cops. I got it down to 2 which is good. I just rebased and pushed another version with a lot more comments and organized the commits slightly differently. Hoping the comments make it easier to merge. |
0470e92
to
3a41979
Compare
wip: going to focus on tests first then will work on getting the remaining commits in |
3a41979
to
37fb722
Compare
Instead of getting into the weeds about how granular our messages are, we are just making sure all the time frames of interest are tested
37fb722
to
b30db11
Compare
Checked commit kbrock@b30db11 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the Thank you for all your contributions! More information about the ManageIQ triage process can be found in the traige process documentation. |
This pull request is not mergeable. Please rebase and repush. |
Did all the work except for combining messages. Doing that in #20071 instead |
extracted / Blocked:
[WIP] Use common context for setting up local miq server #19507Overview
put_or_update
to avoid some of the duplicate work.This PR is focused on queuing.
Before
if
checks on the provider class.After
MetricCapture
objectif
checks, but since there is now a hierarchy, they can use traditional inheritance.