Cu capture move capture queue #19599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the goal is to move from capturing each object individually, to capturing a group of objects in one fell swoop.
this is moving to a class that is not mixed into the individual objects So change them up front before the move
target is passed in since self is no longer the individual target. This commit is probably the one that threw me the most in this chain, because the kind_of will silently fail if you don't add the target there. This code in general is VMWare specific, so getting it into provider specific class is key.
already have ems so no need to lookup per target
Zone is taken from the ems, and only looked up once. This removes the need to cache the zone in the hash. This is possible because perf_capture_queue is now in this file
perf_capture_queue is an internal method now. So there parameters do not need to be checked. The interval is determined from perf_target_to_interval_name, which is 100% under our control, and the options hash, which is from perf_capture_gap or perf_capture_realtime_now. (and the last one is slated to go away soon) Checking on every insert seemed like waste
6 tasks
|
Checked commits kbrock/manageiq@f79ff20~...6c88b86 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
agrare
approved these changes
Dec 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extracted from #19492
For cap&u capture, the logic for putting an ems onto the queue lives in
metrics_capture.rb.This PR moves the logic for putting each ems object onto the queue to
metrics_capture.rb.Before
All vendors put the vm collection requests into the queue in the same way.
VMware specific scenarios like only collecting the past 4 hours of realtime metrics are applied to all vendors.
After
queuing is more streamlines and can be overridden per ems vendor.
No longer looking up queue names and ems multiple times.