Cap&U subclass MetricsCapture #19610
Conversation
Each type of ems captures different targets.
reduce specialized testing methods
this context is only used in one place
these are testing perf_capture_queue
group these using as priority tests use existing miq_server / zone use fewer @ variables
kbrock
force-pushed
the
cu_capture_tests
branch
from
91be010
to
5c3de11
Compare
| @@ -0,0 +1,5 @@ | |||
| class ManageIQ::Providers::CloudManager::MetricsCapture < ManageIQ::Providers::BaseManager::MetricsCapture | |||
| def capture_ems_targets(options = {}) | |||
| Metric::Targets.capture_cloud_targets([ems], options) | |||
There was a problem hiding this comment.
@kbrock is the goal to move all of e.g. capture_cloud_targets into the CloudManager::MetricsCapture class?
There was a problem hiding this comment.
Currently, all MetricsCapture objects subclass BaseManager::MetricsCapture. So the base case will need to call into that method.
Are you thinking about moving that method into BaseManager::MetricsCapture and then removing/moving into the subclass once we are subclassing correctly?
I was thinking that we would introduce the subclassing. Change all providers. Then move/remove capture_cloud_targets.
spec/models/manageiq/providers/base_manager/metrics_capture_spec.rb
Outdated
Show resolved
Hide resolved
It really isn't bad, mostly moving specs around |
|
Checked commits kbrock/manageiq@a344f84~...c7a663e with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 spec/models/manageiq/providers/base_manager/metrics_capture_spec.rb
spec/models/manageiq/providers/cloud_manager/metrics_capture_spec.rb
|
| @@ -0,0 +1,5 @@ | |||
| class ManageIQ::Providers::CloudManager::MetricsCapture < ManageIQ::Providers::BaseManager::MetricsCapture | |||
| def capture_ems_targets(options = {}) | |||
| Metric::Targets.capture_cloud_targets([ems], options) | |||
There was a problem hiding this comment.
Currently, all MetricsCapture objects subclass BaseManager::MetricsCapture. So the base case will need to call into that method.
Are you thinking about moving that method into BaseManager::MetricsCapture and then removing/moving into the subclass once we are subclassing correctly?
I was thinking that we would introduce the subclassing. Change all providers. Then move/remove capture_cloud_targets.
This got bigger than I thought it would.
creates subclasses for MetricsCapture (currently around
capture_ems_targets)put those tests in appropriate place