Cap&U capture interval tests #19623
Merged
Cap&U capture interval tests #19623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbrock
changed the title
|
WIP: blocked on merging other PR |
kbrock
force-pushed
the
cu_capture_intervals
branch
from
e0025ea
to
81c4bb3
Compare
fix test with incorrect title. value for "recent" is same as for "old"
kbrock
force-pushed
the
cu_capture_intervals
branch
from
81c4bb3
to
d06ce81
Compare
|
Checked commits kbrock/manageiq@f6f449b~...d06ce81 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
kbrock
changed the title
agrare
approved these changes
Dec 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(first 5 commits are remnant from #19610 - will remove once that PR is merged)This PR is part of the effort to make cap&u metrics capture provider specific.
This moves the tests focused around intervals over to
metrics_capture_spec.rb.Since this logic may change per provider, want to isolate them best we can.
These tests are a little more verbose. The actual date time frames should be more obvious.