Run MiqServer.status_update in server process #20904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrafanie
force-pushed
the
run_miq_server_status_update_in_server_process
branch
from
1c3d8a7
to
1b1aa03
Compare
|
@agrare I have a followup I'm working on to do the same for other logging here. While this other logging is in the same place, it doesn't blow up so I though it's better to keep it separate so this surgical fix is easy to backport. The other logging is just convenient to be logged in the server/orchestrator process in pods since you don't have mixed server/worker processes logging to the same file. EDIT: PR: #20909 |
Fixes ManageIQ#20835 [Errno::ESRCH]: No such process ... when run from a worker. In appliance/systemd, you can run status_update in the server's workers. In podified, each process is isolated so we must run this, specifically process_status, in the server process. It didn't make sense to run this is in the worker processes anyway so change all installations to run this in the server process.
jrafanie
force-pushed
the
run_miq_server_status_update_in_server_process
branch
from
1b1aa03
to
e2018db
Compare
|
Checked commit jrafanie@e2018db with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint |
jrafanie
added a commit
to jrafanie/manageiq
that referenced
this pull request
Dec 18, 2020
In appliances it doesn't matter since the evm.log is the used by all of the processes with the same server guid, but in podified, these processes are isolated and logging is all over the place. It's more convenient to log this in the server process. Followup to ManageIQ#20904
jrafanie
added a commit
to jrafanie/manageiq
that referenced
this pull request
Dec 18, 2020
In appliances it doesn't matter since the evm.log is the used by all of the processes with the same server guid, but in podified, these processes are isolated and logging is all over the place. It's more convenient to log this in the server process. Followup to ManageIQ#20904
jrafanie
added a commit
to jrafanie/manageiq
that referenced
this pull request
Dec 18, 2020
This change benefits pods by having this logging all in the same log file, like appliances, by making the same server process log these messages. This doesn't affect appliances much but will make finding these log message much easier in pods. Followup to ManageIQ#20904
simaishi
pushed a commit
that referenced
this pull request
Jan 7, 2021
…in_server_process Run MiqServer.status_update in server process (cherry picked from commit e7297f0)
|
Kasparov backport details: |
simaishi
pushed a commit
that referenced
this pull request
Jan 7, 2021
…in_server_process Run MiqServer.status_update in server process (cherry picked from commit e7297f0)
|
Jansa backport details: |
kbrock
pushed a commit
to kbrock/manageiq
that referenced
this pull request
Jan 27, 2021
This change benefits pods by having this logging all in the same log file, like appliances, by making the same server process log these messages. This doesn't affect appliances much but will make finding these log message much easier in pods. Followup to ManageIQ#20904
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20835
[Errno::ESRCH]: No such process ... when run from a worker.
In appliance/systemd, you can run status_update in the server's workers.
In podified, each process is isolated so we must run this, specifically
process_status, in the server process.
It didn't make sense to run this is in the worker processes anyway so
change all installations to run this in the server process.
Note, I'm looking at the surrounding lines in this file and seeing that we're logging stuff in random generic/priority workers and much of it doesn't make sense in pods or even appliances... I'll add
:queue_name => 'miq_server'to them in a followup as they're not BROKEN but just weird. I'll keep this separate since it's broken and more backportable.