settings.yml support string settings values #20908
Conversation
we are going away from storing symbols in settings.yml This change ensures that the symbols in the settings.yml can be replaced with strings and everything will work as it did before
we are updating settings to no longer store symbols. this makes the settings not ruby specifi this also makes settings serializable in json as well
|
Checked commits kbrock/manageiq@bca660a~...e49a49f with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint |
| @@ -963,13 +963,13 @@ | |||
| :worker_monitor: | |||
| :enforce_resource_constraints: false | |||
| :kill_algorithm: | |||
| :name: :used_swap_percent_gt_value | |||
| :name: used_swap_percent_gt_value | |||
There was a problem hiding this comment.
Does the caller not care if it's symbol or string? (same with the other algorithms). Asking because I don't see a corresponding code change like what you did for poll_method.
There was a problem hiding this comment.
I just checked, it uses send so it should be ok.
|
I think this will require a data migration for any existing overrides of these fields. |
I agree but think we can merge this now and do the migration followup. |
|
Agreed, but I don't want us to forget ;) |
@kbrock can you add a work item to ManageIQ/manageiq-api#979 so we don't forget to fix existing settings.yml related values in customer/user databases as that will break what you're trying to solve in the api. |
|
thnx. done. added the TODO line |
Overview
The serialization of symbols in our yaml file is giving us issues when transferring the data over json.
this breaks the react code that is transferring it
See issues in ManageIQ/manageiq-api#979
Change
Most of the symbol values we use are used in send or have a
to_symso the storage format does not matter.This change fixes the one place in our code where we do not have a to_sym
yaml changes
I'm more than happy removing the yaml change, I just wanted us to see the underlying change so we can better visualize this PR.