Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

settings.yml support string settings values #20908

Merged
merged 2 commits into from
Jan 6, 2021
Merged

settings.yml support string settings values #20908

merged 2 commits into from
Jan 6, 2021

Commits on Dec 18, 2020

  1. Update workers to support symbol or string configuration 

    we are going away from storing symbols in settings.yml

This change ensures that the symbols in the settings.yml can be replaced with strings
and everything will work as it did before
    @kbrock
    kbrock committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    bca660a View commit details
    Browse the repository at this point in the history

  2. update settings.yaml symbol => string 

    we are updating settings to no longer store symbols.
this makes the settings not ruby specifi
this also makes settings serializable in json as well
    @kbrock
    kbrock committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    e49a49f View commit details
    Browse the repository at this point in the history