Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two migrations for Azure resource groups #5026

Merged
merged 2 commits into from
Oct 21, 2015
Merged

Two migrations for Azure resource groups #5026

merged 2 commits into from
Oct 21, 2015

Conversation

bronaghs
Copy link

This PR addresses the DB changes, described below, required for the modeling of Azure ResourceGroups.

  1. The creation of a new resource_groups table
  2. The addition of the resource_group_id column to the existing vms table. This will support the has_many association between a Resource Group and the VMs in it.

A separate PR will be made for the model changes.

Fryguy
Fryguy reviewed Oct 21, 2015
View reviewed changes
db/migrate/20151019184531_create_resource_groups.rb
create_table :resource_groups do |t|
t.string :name
t.string :ems_ref
t.integer :ems_id
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a bigint.

@bronaghs
Copy link
Author

Updated PR:
Changed ems_id from int to bigint
Addressed rubocop complaint around not using hash rocket syntax.

@miq-bot
Copy link
Member

miq-bot commented Oct 21, 2015

Checked commits bronaghs/manageiq@89077d1~...0424f27 with ruby 1.9.3, rubocop 0.34.2, and haml-lint 0.13.0
2 files checked, 0 offenses detected
Everything looks good. 👍

@Fryguy
Copy link
Member

Fryguy commented Oct 21, 2015

👍

Fryguy added a commit that referenced this pull request Oct 21, 2015
@Fryguy
Merge pull request #5026 from bronaghs/azure_resource_group_db_migrat…
fd11e99 
…ions

Two migrations for Azure resource groups
@Fryguy Fryguy merged commit fd11e99 into ManageIQ:master Oct 21, 2015
@Fryguy Fryguy deleted the azure_resource_group_db_migrations branch October 21, 2015 20:30
@Fryguy Fryguy added this to the Sprint 31 Ending Oct 26, 2015 milestone Oct 21, 2015
@bronaghs bronaghs mentioned this pull request Oct 23, 2015
Merged
@isimluk isimluk mentioned this pull request Mar 10, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement providers/cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bronaghs @miq-bot @Fryguy