Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure - New ResourceGroup model #5086

Merged
merged 1 commit into from
Oct 24, 2015

Conversation

bronaghs
Copy link

This PR will add a new model for the Azure Resource Group.
A migration for this new model was already merged here: #5026
A separate PR will be made to add a resource_group_id to the Vm model.

@miq-bot
Copy link
Member

miq-bot commented Oct 23, 2015

Checked commit bronaghs@4d789b0 with ruby 1.9.3, rubocop 0.34.2, and haml-lint 0.13.0
3 files checked, 0 offenses detected
Everything looks good. 👍

@chessbyte
Copy link
Member

@bronaghs Is a migration needed to create resource_groups table? Or was that done in a previous PR?

@bzwei
Copy link
Contributor

bzwei commented Oct 23, 2015

@chessbyte the migration was merged in #5026.
@bronaghs from the migration, why the table has ems_ref and ems_id? I think ems_ref is sufficient. Also why there is no column for location which is included in the return from the API?

@Fryguy
Copy link
Member

Fryguy commented Oct 24, 2015

ems_ref != ems_id . The former is a key from Azure, the latter is the reference to record in the ext_management_systems table.

Fryguy added a commit that referenced this pull request Oct 24, 2015
@Fryguy Fryguy merged commit 1e56636 into ManageIQ:master Oct 24, 2015
@Fryguy Fryguy deleted the azure_resource_groups branch October 24, 2015 03:59
@Fryguy Fryguy added this to the Sprint 31 Ending Oct 26, 2015 milestone Oct 24, 2015
@bronaghs
Copy link
Author

@bzwei - Azure locations will be called Regions in MIQ. Regions in Azure will be mirror Regions in AWS where a Region is its own EMS. Therefore the association between the ResourceGroup and the Region will be represented by the existing ems_id column.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants