Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gemfile.lock #567

Merged
merged 3 commits into from
Aug 31, 2021
Merged

Update Gemfile.lock #567

merged 3 commits into from
Aug 31, 2021

Conversation

agrare
Copy link
Member

@agrare agrare commented Aug 24, 2021

No description provided.

@NickLaMuro
Copy link
Member

@agrare Could we also update thin to 1.8.0? I have run into this issue more times than I can remember, and it gets me every time:

We can do it as a separate PR as well if people prefer.

@@ -360,25 +354,26 @@ GEM
sync (0.5.0)
sysexits (1.2.0)
temple (0.8.2)
thin (1.7.2)
thin (1.8.1)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely @NickLaMuro ☝️

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! You did a generic bundle update, not just for celluloid. Cool beans. Thanks!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah celluloid was the only one which was failing on the latest version so I limited it to the prior version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

celluloid was all the rage for a while but died out after sidekick rewrote to not include it.
TBH, kinda surprised to see it.

Copy link
Member

@NickLaMuro NickLaMuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I will let someone else merged like @bdunne or @Fryguy

@agrare agrare force-pushed the update_gemfile_lock branch from 0a217b0 to 2820b28 Compare August 31, 2021 11:45
Fixes `Cannot proxy frozen objects, rspec-mocks relies on proxies for
method stubbing and expectations.`
@agrare agrare force-pushed the update_gemfile_lock branch from 2820b28 to 214e43f Compare August 31, 2021 11:45
@miq-bot
Copy link
Member

miq-bot commented Aug 31, 2021

Checked commits agrare/miq_bot@4bb209b~...214e43f with ruby 2.6.3, rubocop 1.13.0, haml-lint 0.35.0, and yamllint
2 files checked, 0 offenses detected
Everything looks fine. 👍

@bdunne bdunne merged commit b8afd16 into ManageIQ:master Aug 31, 2021
@bdunne bdunne self-assigned this Aug 31, 2021
@bdunne bdunne added the dependencies Pull requests that update a dependency file label Aug 31, 2021
@agrare agrare deleted the update_gemfile_lock branch August 31, 2021 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants