fix: update parser header file with namespaced functions #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't install another gem that has thin as a dependency because of this error. Thank you for this PR and for the workaround. It solved the problem. |
This was referenced Aug 3, 2020
8 tasks
|
Thanks for the pull request! Could someone tag a new release please? Has it really been 3 years? :) https://rubygems.org/gems/thin/versions/1.7.2 |
jamescdavis
deleted the
update_parser_header_file_with_namespaced_functions
branch
|
Yes we will do a new release soon, it will probably be 1.8.0. |
|
@ioquatix Thank you. Friendly reminder: would you mind releasing a new version? With XCode v12 becoming the default, a number of people are hitting this error. |
|
@ioquatix any update on this? |
brettchalupa
pushed a commit
to bigcartel/dugway
that referenced
this pull request
Nov 23, 2020
It appears that there are issues with it on MacOS Big Sur, and the 1.8.0 ver of Thin has a fix for what I believe to be the issue: macournoyer/thin#364 Fixes #182
This was referenced Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
d5b523e renamed the parser functions to include a
thin_prefix as a namespace, but did not update the parser header file. This did not cause any problems for a long time becauseimplicit-function-declarationwas just a warning previously, but Xcode 12 has made it an error (second bullet under Apple Clang Compiler > Resolved):This is preventing install of this gem on macOS with Xcode 12.
Note: there is a workaround until this is patched:
$ gem install thin -- --with-cflags="-Wno-error=implicit-function-declaration"or with Bundler:
$ bundle config build.thin --with-cflags="-Wno-error=implicit-function-declaration"