Fix double modications #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
jalew188
reviewed
Jun 25, 2024
jalew188
approved these changes
Jun 27, 2024
yes I did |
mschwoer
requested review from
jalew188,
GeorgWa,
boopthesnoot,
ammarcsj and
vbrennsteiner
GeorgWa
approved these changes
Jun 28, 2024
jalew188
reviewed
Nov 18, 2024
| 'Acetyl@Protein N-term': | ||
| - '_(Acetyl (Protein N-term))' | ||
| 'Acetyl@Protein_N-term': | ||
| - '_(Acetyl (Protein_N-term))' |
There was a problem hiding this comment.
The actual unimod names contain a space, so we cannot modify the MQ source PTM names
There was a problem hiding this comment.
released in 1.3.0, fixed here for 1.4.2: #241
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issues discovered here #186
by removing the double-bookeeping in the modifications.
@jalew188 and me decided to break the public API (the methods in
modifications.py) but not the reading of speclib filesThis is how is looks like in alphaDIA:
Please check very carefully this breaks something you know about