Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move deserialization of manta-pay types into the extrinsic #470

Merged
merged 5 commits into from
Apr 1, 2022

Conversation

bhgomes
Copy link
Contributor

@bhgomes bhgomes commented Mar 31, 2022

Description

Unfortunately, there is an error during SCALE deserialization of the custom arkworks types for the manta-pay pallet. For now, the workaround is to move the deserialization into the extrinsic calls instead of having the RPC code perform the deserialization ahead of time. NB: This is a temporary fix and will need to be resolved at some point.

DEPENDS ON: Manta-Network/manta-rs#42


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests.
  • Updated relevant documentation in the code.
  • Added one line describing your change in <branch>/CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer.
  • If runtime changes, need to update the version numbers properly:
    • authoring_version: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.
    • spec_version: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.
    • impl_version: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.
    • transaction_version: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. If this number is updated, then the spec_version must also be updated
  • Verify benchmarks & weights have been updated for any modified runtime logics
  • If import a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are offcially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inhreited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

@bhgomes bhgomes marked this pull request as draft March 31, 2022 14:50
@github-actions
Copy link

Please signoff on all commits with your name, email and gpg key for the Developer's Certificate of Origin.
git config --global user.name your_name
git config --global user.email you_email
COMMAND : git commit -s -S -m your_commit_message
-s = Signed-off-by
-S = Verify commit using gpg key
If there is more than one commit in your pull request and your git client is modern enough (2.13+), rebase the required number of commits with --signoff:
git rebase --signoff HEAD~<number_of_commits>
Then, force push:
git push -f origin <your_branch>
For instructions on managing gpg signature verification please visit: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

@bhgomes bhgomes marked this pull request as ready for review April 1, 2022 12:46
@bhgomes bhgomes requested a review from stechu April 1, 2022 12:46
@bhgomes bhgomes changed the title fix: move deserialization of manta-pay proof into the extrinsic fix: move deserialization of manta-pay types into the extrinsic Apr 1, 2022
@bhgomes bhgomes marked this pull request as draft April 1, 2022 12:49
bhgomes added 3 commits April 1, 2022 10:38
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes bhgomes force-pushed the fix/deserialize-proof branch from baf96a6 to 0c30056 Compare April 1, 2022 14:38
@bhgomes bhgomes marked this pull request as ready for review April 1, 2022 14:45
stechu added 2 commits April 1, 2022 16:52
Signed-off-by: Shumo Chu <shumo.chu@protonmail.com>
Signed-off-by: Shumo Chu <shumo.chu@protonmail.com>
@stechu stechu merged commit d777ca6 into manta Apr 1, 2022
@stechu stechu deleted the fix/deserialize-proof branch April 1, 2022 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants