Convert Back to Async Wallet Interface #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhgomes
requested review from
stechu,
tsunrise and
Kevingislason
and removed request for
a team and
stechu
10 tasks
stechu
approved these changes
Apr 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to convert the Wallet interface back into
asyncto support Javascript interoperability. JS-based wallets must be able to run fully asynchronously because interfacing with the blockchain state is an asynchronous operation (using polkadot-JS) and once you useasyncin Javascript, you can no longer block the application, ever.This PR also adds more infrastructure to support simulated HTTP communication between the mock ledger and wallet as well as simulation API that simplifies simulating against
manta-signer.