Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update parameter path from sdk to manta-parameters #622

Merged
merged 4 commits into from
Jun 21, 2022

Conversation

BoyuanFeng
Copy link
Contributor

@BoyuanFeng BoyuanFeng commented Jun 20, 2022

Signed-off-by: Boyuan Feng bfeng9@wisc.edu

Description

In manta-rs v0.5.1, we have moved public parameters from sdk to manta-parameters. This requires a dependency change in pallet-manta-pay and a tag update for manta-rs crates from v0.5.0 to v0.5.1.

We also update the random number generator from thread_rng to OsRng, removing an unnecessary rand dependency. In one other case, where we need deterministic RNG, we use fixed-seed ChaCha-based RNG and import the rand_chacha crate for this. (The rand_chacha crate is the canonical ChaCha implementation in Rust and is used in manta-rs).

closes: #605


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests.
  • Updated relevant documentation in the code.
  • Added one line describing your change in <branch>/CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer.
  • If runtime changes, need to update the version numbers properly:
    • authoring_version: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.
    • spec_version: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.
    • impl_version: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.
    • transaction_version: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. You can run the metadata_diff.yml workflow for help. If this number is updated, then the spec_version must also be updated
  • Verify benchmarks & weights have been updated for any modified runtime logics
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

Signed-off-by: Boyuan Feng <bfeng9@wisc.edu>
@BoyuanFeng BoyuanFeng self-assigned this Jun 20, 2022
@BoyuanFeng BoyuanFeng added the A-polkadot-dependency Area: Issues and PRs related to Polkadot as a Dependency label Jun 20, 2022
@BoyuanFeng BoyuanFeng added this to the v3.2.1 milestone Jun 20, 2022
Signed-off-by: Boyuan Feng <bfeng9@wisc.edu>
@BoyuanFeng BoyuanFeng requested a review from bhgomes June 20, 2022 20:37
Signed-off-by: Boyuan Feng <bfeng9@wisc.edu>
@BoyuanFeng BoyuanFeng requested a review from Garandor June 20, 2022 20:42
bhgomes
bhgomes previously approved these changes Jun 20, 2022
@github-actions
Copy link

Please signoff on all commits with your name, email and gpg key for the Developer's Certificate of Origin.
git config --global user.name your_name
git config --global user.email you_email
COMMAND : git commit -s -S -m your_commit_message
-s = Signed-off-by
-S = Verify commit using gpg key
If there is more than one commit in your pull request and your git client is modern enough (2.13+), rebase the required number of commits with --signoff:
git rebase --signoff HEAD~<number_of_commits>
Then, force push:
git push -f origin <your_branch>
For instructions on managing gpg signature verification please visit: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

Signed-off-by: Boyuan Feng <bfeng9@wisc.edu>
@BoyuanFeng BoyuanFeng force-pushed the feat/manta-parameters branch from 34d6936 to fa64b4a Compare June 20, 2022 21:28
Copy link
Contributor

@Garandor Garandor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor description nits and a question about safety of switching to a new-ish crate

Cargo.lock Show resolved Hide resolved
pallets/manta-pay/Cargo.toml Show resolved Hide resolved
pallets/manta-pay/Cargo.toml Show resolved Hide resolved
@ghzlatarev ghzlatarev merged commit 799bcb6 into manta Jun 21, 2022
@ghzlatarev ghzlatarev deleted the feat/manta-parameters branch June 21, 2022 08:28
@Garandor Garandor mentioned this pull request Jun 30, 2022
10 tasks
@bhgomes bhgomes removed the A-polkadot-dependency Area: Issues and PRs related to Polkadot as a Dependency label Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move to new Public Parameter Location
4 participants