-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update parameter path from sdk
to manta-parameters
#622
Conversation
Signed-off-by: Boyuan Feng <bfeng9@wisc.edu>
Signed-off-by: Boyuan Feng <bfeng9@wisc.edu>
Signed-off-by: Boyuan Feng <bfeng9@wisc.edu>
Please signoff on all commits with your name, email and gpg key for the Developer's Certificate of Origin. |
Signed-off-by: Boyuan Feng <bfeng9@wisc.edu>
34d6936
to
fa64b4a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor description nits and a question about safety of switching to a new-ish crate
Signed-off-by: Boyuan Feng bfeng9@wisc.edu
Description
In
manta-rs v0.5.1
, we have moved public parameters fromsdk
tomanta-parameters
. This requires a dependency change inpallet-manta-pay
and a tag update formanta-rs
crates fromv0.5.0
tov0.5.1
.We also update the random number generator from
thread_rng
toOsRng
, removing an unnecessaryrand
dependency. In one other case, where we need deterministic RNG, we use fixed-seed ChaCha-based RNG and import therand_chacha
crate for this. (Therand_chacha
crate is the canonical ChaCha implementation in Rust and is used inmanta-rs
).closes: #605
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
<branch>/CHANGELOG.md
Files changed
in the Github PR explorer.authoring_version
: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.spec_version
: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.impl_version
: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.transaction_version
: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. You can run themetadata_diff.yml
workflow for help. If this number is updated, then thespec_version
must also be updatedBaseFilter
. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.try-runtime
. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of#[pallet::storage]
items to check for any.