Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move concrete parameters from manta-sdk to manta-parameters #102

Merged
merged 8 commits into from
Jun 14, 2022
Merged

feat: move concrete parameters from manta-sdk to manta-parameters #102

merged 8 commits into from
Jun 14, 2022

Conversation

BoyuanFeng
Copy link
Contributor

@BoyuanFeng BoyuanFeng commented Jun 14, 2022 •
edited
Loading

Summary

Move concrete parameters from manta-sdk to manta-parameters

Details

This PR moves (partly) the following files from manta-sdk to manta-rs:

This PR is the first step to solving #100.

Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.

@bhgomes bhgomes added the changelog:added Changelog: add these changes to the `added` section of the changelog label Jun 14, 2022
@bhgomes bhgomes modified the milestones: v1.0.0, v0.6.0 Jun 14, 2022
@bhgomes bhgomes changed the title wip: move concrete parameters from manta-sdk to manta-parameters feat: move concrete parameters from manta-sdk to manta-parameters Jun 14, 2022
@bhgomes bhgomes mentioned this pull request Jun 14, 2022
Closed
@bhgomes bhgomes mentioned this pull request Jun 14, 2022
Closed
6 tasks
@BoyuanFeng BoyuanFeng self-assigned this Jun 14, 2022
@BoyuanFeng BoyuanFeng mentioned this pull request Jun 14, 2022
Merged
4 tasks
@bhgomes bhgomes requested review from bhgomes, tsunrise and stechu June 14, 2022 20:15
bhgomes
bhgomes suggested changes Jun 14, 2022
View reviewed changes
Copy link
Contributor

@bhgomes bhgomes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a few comments before merge. Also, make sure to run the following in the manta-parameters directory to setup the LFS system:

git lfs track "*.lfs"

manta-parameters/README.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
manta-parameters/Cargo.toml Outdated Show resolved Hide resolved
manta-parameters/Cargo.toml Outdated Show resolved Hide resolved
manta-parameters/Cargo.toml Outdated Show resolved Hide resolved
manta-parameters/Cargo.toml Outdated Show resolved Hide resolved
manta-parameters/Cargo.toml Outdated Show resolved Hide resolved
manta-pay/Cargo.toml Outdated Show resolved Hide resolved
manta-parameters/src/lib.rs Outdated Show resolved Hide resolved
@bhgomes bhgomes merged commit 83bc346 into main Jun 14, 2022
@bhgomes bhgomes deleted the feat/manta-parameters branch June 14, 2022 22:31
@bhgomes bhgomes modified the milestones: v0.6.0, v0.5.1 Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhgomes bhgomes bhgomes approved these changes

@stechu stechu stechu approved these changes

@tsunrise tsunrise Awaiting requested review from tsunrise

Assignees

@BoyuanFeng BoyuanFeng

Labels
changelog:added Changelog: add these changes to the `added` section of the changelog
Projects
None yet
Milestone
v0.5.1
Development

Successfully merging this pull request may close these issues.
3 participants
@BoyuanFeng @stechu @bhgomes