less bound checks and only need to check half the elements on symmetric. #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhgomes
added
P-low
bhgomes
suggested changes
Aug 23, 2022
Comment on lines
+148
to
+151
| // Check the lower triangle against the upper triangle | ||
| for (i, element) in self.0.iter().enumerate() { | ||
| for (j, inner_element) in element.iter().enumerate().skip(i + 1) { | ||
| if !F::eq(&inner_element, &self.0[j][i]) { |
There was a problem hiding this comment.
Suggested change
| // Check the lower triangle against the upper triangle | |
| for (i, element) in self.0.iter().enumerate() { | |
| for (j, inner_element) in element.iter().enumerate().skip(i + 1) { | |
| if !F::eq(&inner_element, &self.0[j][i]) { | |
| for (i, element) in self.0.iter().enumerate() { | |
| for (j, inner_element) in element.iter().enumerate().skip(i + 1) { | |
| if inner_element != &self.0[j][i] { |
Comment on lines
+130
to
+132
| for (i, element) in self.0.iter().enumerate() { | ||
| for (j, inner_element) in element.iter().enumerate() { | ||
| if !F::eq(&inner_element, &kronecker_delta(i, j)) { |
There was a problem hiding this comment.
Suggested change
| for (i, element) in self.0.iter().enumerate() { | |
| for (j, inner_element) in element.iter().enumerate() { | |
| if !F::eq(&inner_element, &kronecker_delta(i, j)) { | |
| for (i, element) in self.0.iter().enumerate() { | |
| for (j, inner_element) in element.iter().enumerate() { | |
| if inner_element != &kronecker_delta(i, j) { |
|
Moved to #212. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Also given how small
kronecker_deltais we should hint to rustc that it should be inlined.)Before we can merge this PR, please make sure that all the following items have been checked off:
CHANGELOG.mdand added the appropriatechangeloglabel to the PR.Files changedin the GitHub PR explorer.CONTRIBUTING.md.