Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less Bounds Checks on Matrix Operations #212

Merged
merged 5 commits into from
Aug 23, 2022

Conversation

bhgomes
Copy link
Contributor

@bhgomes bhgomes commented Aug 23, 2022

  • Reduces the number of checks when computing is_identity and is_symmetric

Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.
  • Ran cargo hakari generate to update the workspace-hack system

@bhgomes bhgomes changed the title Less Bounds Checks on Matrix Code Less Bounds Checks on Matrix Operations Aug 23, 2022
@bhgomes bhgomes added this to the v1.0.0 milestone Aug 23, 2022
@bhgomes bhgomes added A-performance Area: Performance-related Issues and PRs changelog:fixed Changelog: add these changes to the `fixed` section of the changelog P-low Priority: Low labels Aug 23, 2022
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes bhgomes requested review from BoyuanFeng and tsunrise August 23, 2022 05:47
@bhgomes bhgomes marked this pull request as ready for review August 23, 2022 05:47
@BoyuanFeng BoyuanFeng merged commit 6297cb8 into main Aug 23, 2022
@BoyuanFeng BoyuanFeng deleted the gilescope-giles-less-bounds-checks branch August 23, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-performance Area: Performance-related Issues and PRs changelog:fixed Changelog: add these changes to the `fixed` section of the changelog P-low Priority: Low
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants