Simplify multi-pickup or multi-delivery shipments #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove dead code Fix y_ids= operators Find raises if id does not exists Add getter for has_many ids Fix id getter of belongs_to Functions keep the id(s) up-to-date Generate only necessary id functions Generate only correct ids functions
senhalil
force-pushed
the
feat/simplify_multi_pickup_or_multi_delivery_shipments
branch
from
f73e4e2
to
6891323
Compare
senhalil
force-pushed
the
feat/simplify_multi_pickup_or_multi_delivery_shipments
branch
from
6891323
to
7c429ce
Compare
senhalil
force-pushed
the
feat/simplify_multi_pickup_or_multi_delivery_shipments
branch
3 times, most recently
from
52499ae
to
3c6c1e8
Compare
fonsecadeline
approved these changes
Aug 6, 2021
senhalil
force-pushed
the
feat/simplify_multi_pickup_or_multi_delivery_shipments
branch
from
3c6c1e8
to
f580e5f
Compare
TODO: after validation this logic can be moved to base.rb
TODO: a "shallow_copy" version can be implemented by "prioritizing"
id-methods instead of non-id methods during copy, and by reverting
the override logic via options[:key_id]
senhalil
force-pushed
the
feat/simplify_multi_pickup_or_multi_delivery_shipments
branch
from
f580e5f
to
0755733
Compare
fab-girard
approved these changes
Aug 10, 2021
senhalil
deleted the
feat/simplify_multi_pickup_or_multi_delivery_shipments
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a simplification routine to simplify complex shipments into a multiple simple shipments
Adds a deep_copy helper function that can be moved into base.rb (with some modification after testing)
Logs the simplification operations in a uniform way
Needs Improve base.rb & update active_hash #254 to be merged first
Closes optimizer-api/-/issues/785