Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify multi-pickup or multi-delivery shipments #261

Merged
merged 17 commits into from
Aug 10, 2021
Merged

Simplify multi-pickup or multi-delivery shipments #261

merged 17 commits into from
Aug 10, 2021

Commits on Aug 2, 2021

  1. Improve base.rb 

    Remove dead code
Fix y_ids= operators
Find raises if id does not exists
Add getter for has_many ids
Fix id getter of belongs_to
Functions keep the id(s) up-to-date
Generate only necessary id functions
Generate only correct ids functions
    @senhalil
    senhalil committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    cd94b1d View commit details
    Browse the repository at this point in the history

  2. duplicate_safe calls create & respects options

    @senhalil
    senhalil committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    6102e96 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2021

  1. Use Models::X.create and not .new

    @senhalil
    senhalil committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    513905d View commit details
    Browse the repository at this point in the history

  2. CostDetails calculates totals expressively

    @senhalil
    senhalil committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    a1176bf View commit details
    Browse the repository at this point in the history

  3. active_hash validates the IDs correctly

    @senhalil
    senhalil committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    61c5ba0 View commit details
    Browse the repository at this point in the history

  4. Auto generated IDs are integer

    @senhalil
    senhalil committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    d36ce07 View commit details
    Browse the repository at this point in the history

  5. Test: optimize only once to do multiple GETs

    @senhalil
    senhalil committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    6966d6a View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2021

  1. Fix suffix typo

    @senhalil
    senhalil authored Aug 10, 2021
    Configuration menu
    Copy the full SHA
    c6aa5c2 View commit details
    Browse the repository at this point in the history

  2. Relation handles the expansion itself

    @senhalil
    senhalil committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    f509e2c View commit details
    Browse the repository at this point in the history

  3. Prevent vrp.create function side-effects

    @senhalil
    senhalil committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    3cc7461 View commit details
    Browse the repository at this point in the history

  4. Validate relations wrt scheduling service params

    @senhalil
    senhalil committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    8c4a1ca View commit details
    Browse the repository at this point in the history

  5. Clean dead logic in ortools.rb

    @senhalil
    senhalil committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    8b22f63 View commit details
    Browse the repository at this point in the history

  6. Helper deep_copy function 

    TODO: after validation this logic can be moved to base.rb
TODO: a "shallow_copy" version can be implemented by "prioritizing"
      id-methods instead of non-id methods during copy, and by reverting
			the override logic via options[:key_id]
    @senhalil
    senhalil committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    bb74f94 View commit details
    Browse the repository at this point in the history

  7. Log active simplification operations

    @senhalil
    senhalil committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    eb3ee25 View commit details
    Browse the repository at this point in the history

  8. Fix TEST_DUMP_VRP logic

    @senhalil
    senhalil committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    c95d815 View commit details
    Browse the repository at this point in the history

  9. Add: simplify complex shipments -> multiple simple

    @senhalil
    senhalil committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    d7bc5cc View commit details
    Browse the repository at this point in the history

  10. Update CHANGELOG.md

    @senhalil
    senhalil committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    0755733 View commit details
    Browse the repository at this point in the history