Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent the default scrolling event of spacebar when focus is on map #724

Merged
merged 6 commits into from
Jan 25, 2023
Merged

prevent the default scrolling event of spacebar when focus is on map #724

merged 6 commits into from
Jan 25, 2023

Conversation

yhy0217
Copy link
Contributor

@yhy0217 yhy0217 commented Jan 24, 2023 •
edited
Loading

Closes #694

  • Update web-map.js
  • Add test for web-map.js

@AliyanH
Copy link
Member

AliyanH commented Jan 24, 2023

f81681f also resolves #719

@AliyanH AliyanH linked an issue Jan 24, 2023 that may be closed by this pull request
Pasting Layer (using ctrl+v) with 2 mapml-viewers in the document, duplicates the layer #719
Closed
prushforth
prushforth approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@prushforth prushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I listened to the experiments with this PR running, and the maps sound good. Let's merge it!

Good job!

AliyanH
AliyanH approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@AliyanH AliyanH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good work

@AliyanH AliyanH marked this pull request as ready for review January 25, 2023 18:42
@AliyanH AliyanH merged commit 249b22b into Maps4HTML:main Jan 25, 2023
@yhy0217 yhy0217 deleted the preventScrollingEvent branch January 25, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AliyanH AliyanH AliyanH approved these changes

@prushforth prushforth prushforth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@yhy0217 @AliyanH @prushforth