Skip to content

Commit

Permalink
Add video params to Beachfront adapter (prebid#3121)
Browse files Browse the repository at this point in the history
* add playback method to video targeting

* bump adapter version

* add maxduration to video targeting
  • Loading branch information
jsalis authored and Pedro López Jiménez committed Mar 18, 2019
1 parent bdb0384 commit 2915480
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
4 changes: 2 additions & 2 deletions modules/beachfrontBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,15 @@ import { VIDEO, BANNER } from 'src/mediaTypes';
import find from 'core-js/library/fn/array/find';
import includes from 'core-js/library/fn/array/includes';

const ADAPTER_VERSION = '1.2';
const ADAPTER_VERSION = '1.3';
const ADAPTER_NAME = 'BFIO_PREBID';
const OUTSTREAM = 'outstream';

export const VIDEO_ENDPOINT = '//reachms.bfmio.com/bid.json?exchange_id=';
export const BANNER_ENDPOINT = '//display.bfmio.com/prebid_display';
export const OUTSTREAM_SRC = '//player-cdn.beachfrontmedia.com/playerapi/loader/outstream.js';

export const VIDEO_TARGETING = ['mimes'];
export const VIDEO_TARGETING = ['mimes', 'playbackmethod', 'maxduration'];
export const DEFAULT_MIMES = ['video/mp4', 'application/javascript'];

let appId = '';
Expand Down
6 changes: 4 additions & 2 deletions test/spec/modules/beachfrontBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -218,11 +218,13 @@ describe('BeachfrontAdapter', function () {
it('must override video targeting params', function () {
const bidRequest = bidRequests[0];
const mimes = ['video/webm'];
const playbackmethod = 2;
const maxduration = 30;
bidRequest.mediaTypes = { video: {} };
bidRequest.params.video = { mimes };
bidRequest.params.video = { mimes, playbackmethod, maxduration };
const requests = spec.buildRequests([ bidRequest ]);
const data = requests[0].data;
expect(data.imp[0].video).to.deep.contain({ mimes });
expect(data.imp[0].video).to.deep.contain({ mimes, playbackmethod, maxduration });
});

it('must add GDPR consent data to the request', function () {
Expand Down

0 comments on commit 2915480

Please sign in to comment.