Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add video params to Beachfront adapter #3121

Merged
merged 3 commits into from
Sep 27, 2018

Conversation

jsalis
Copy link
Contributor

@jsalis jsalis commented Sep 24, 2018

Type of change

  • Feature
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

Description of change

Adds bidder params to pass video playback method and max duration.

{
  bidder: 'beachfront',
  params: {
    bidfloor: 0.01,
    appId: '3b16770b-17af-4d22-daff-9606bdf2c9c3'
    video: {
      playbackmethod: 1,
      maxduration: 30
    }
  }
}

PR for docs:
prebid/prebid.github.io#974

@jsalis jsalis changed the title Add playback method param to Beachfront adapter Add video params to Beachfront adapter Sep 25, 2018
@harpere harpere self-requested a review September 25, 2018 17:00
@harpere harpere self-assigned this Sep 25, 2018
@harpere harpere added LGTM and removed needs review labels Sep 27, 2018
@harpere harpere merged commit cea3f1e into prebid:master Sep 27, 2018
ArmandChoy pushed a commit to RockYou-Ads/Prebid.js that referenced this pull request Sep 28, 2018
* 'master' of https://github.com/prebid/Prebid.js: (367 commits)
  Rubicon adapter: get referrer from bidderRequest.refererInfo.referer; (prebid#3087)
  Minor freewheel-ssp update (prebid#3119)
  fixes prebid#3128 YieldlabBidAdapter is not using bidRequest.params.adSize (prebid#3129)
  Support Video Renderer (prebid#3104)
  Fix for Issue 3130: passing new copy of adUnits object to every adapter (prebid#3131)
  Add video params to Beachfront adapter (prebid#3121)
  Sonobi - Fix ref encoding (prebid#3125)
  update circleci link to just Prebid.js builds (prebid#3132)
  Bugfix: Issue 3111 (prebid#3122)
  increment prebid version
  Prebid 1.25.0 Release
  adding account to s2s bidder-sync request (prebid#3123)
  Revert "Trafficroots Bid Adapter Submission (prebid#2993)" (prebid#3124)
  Trafficroots Bid Adapter Submission (prebid#2993)
  add versioning and deprecation policy doc (prebid#3103)
  improving kargo unit tests for currency handling (prebid#3106)
  AdOcean adapter improvment (prebid#3011)
  Serverbid Bid Adapter: Add pubnx alias (prebid#3064)
  Adds an id parameter (prebid#3107)
  added sizes for rubicon (prebid#3094)
  ...
@jsalis jsalis deleted the feature/add-video-params branch September 28, 2018 23:04
pedrolopezmrf pushed a commit to Marfeel/Prebid.js that referenced this pull request Mar 18, 2019
* add playback method to video targeting

* bump adapter version

* add maxduration to video targeting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants