Rubicon adapter: get referrer from bidderRequest.refererInfo.referer; #3087

AntoineJac · 2018-09-13T08:25:13Z

Appnexus new module is passing the encoded url and sometimes Publisher are passing encoded url in the referrer parameter.
This fix is a protection in case a module is update and start passing encode url. Our AE is not decoding and from some test I did, monetisation could be highly impacted.

Type of change

Bugfix
Feature
New bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other

Description of change

test parameters for validating bids

{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

contact email of the adapter’s maintainer
official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

A link to a PR on the docs repo at https://github.com/prebid/prebid.github.io/

Other information

Appnexus new module is passing the encoded url and sometimes Publisher are passing encoded url in the referrer parameter. This fix is a protection in case a module is update and start passing encode url. Our AE is not decoding and from some test I did, monetisation could be highly impacted.

mkendall07 · 2018-09-13T16:12:26Z

@AntoineJac
you have some test failure.

AntoineJac · 2018-09-14T07:02:27Z

@mkendall07 , thanks I indeed forget to push the new specs.
@bretg , can you please review?

harpere · 2018-09-14T13:56:55Z

modules/rubiconBidAdapter.js

 }
- return bidRequest.params.secure ? pageUrl.replace(/^http:/i, 'https:') : pageUrl;
+ let _pageUrl = bidRequest.params.secure ? pageUrl.replace(/^http:/i, 'https:') : pageUrl;
+ return decodeURIComponent(_pageUrl.replace(/\+/g, ' '))


the title of the PR says, "DecodeUrl if url is encoded". Do we need to check first if it's encoded?

question - should we update the referer module to return unencoded referer? I'm sort of on the fence on this but curious to get other's input.

@harpere , I guess that if the url is decoded, decoding should not provoke any error.

@mkendall07 , I would indeed recommend returning decoding url as other partner may face some issues.

@AntoineJac - I think decoding again might only make a difference if there was a % in the referrer. But if we know the module is encoding, we're fine.

@mkendall07 - my impulse is that the module should NOT encoded referer and let the adapter encode it if they need to. Let us know if you decide to change it and we'll change our implementation. not a bid deal either way.

bretg · 2018-09-19T17:58:12Z

Which 'Appnexus module' is generating this URL? Is this the new 'referer detection' PR #3067 ?

Assigning to @mkendall07 to make a call here - we'll abandon this PR if referer detection flips the change. But since that's a breaking change, am guessing a change at this point would be hard.

mkendall07 · 2018-09-19T18:05:07Z

@bretg thanks. yes we should not encode the referral in the referer detection module. @jaiminpanchal27 will make the change and you can update this PR as required or just close it.

CC:
@harpere @AntoineJac

mkendall07

Need to update the refer detection API first.

bretg · 2018-09-26T13:41:43Z

Closing this -- resolved by #3116

bretg · 2018-09-27T03:38:48Z

re-opening so @AntoineJac can update it to remove the decode part (and update title)

AntoineJac · 2018-09-28T06:00:13Z

@bretg , PR is ready for reviewing.
Thanks,

* 'master' of https://github.com/prebid/Prebid.js: (367 commits) Rubicon adapter: get referrer from bidderRequest.refererInfo.referer; (prebid#3087) Minor freewheel-ssp update (prebid#3119) fixes prebid#3128 YieldlabBidAdapter is not using bidRequest.params.adSize (prebid#3129) Support Video Renderer (prebid#3104) Fix for Issue 3130: passing new copy of adUnits object to every adapter (prebid#3131) Add video params to Beachfront adapter (prebid#3121) Sonobi - Fix ref encoding (prebid#3125) update circleci link to just Prebid.js builds (prebid#3132) Bugfix: Issue 3111 (prebid#3122) increment prebid version Prebid 1.25.0 Release adding account to s2s bidder-sync request (prebid#3123) Revert "Trafficroots Bid Adapter Submission (prebid#2993)" (prebid#3124) Trafficroots Bid Adapter Submission (prebid#2993) add versioning and deprecation policy doc (prebid#3103) improving kargo unit tests for currency handling (prebid#3106) AdOcean adapter improvment (prebid#3011) Serverbid Bid Adapter: Add pubnx alias (prebid#3064) Adds an id parameter (prebid#3107) added sizes for rubicon (prebid#3094) ...

…prebid#3087) * DecodeUrl if url is encoded Appnexus new module is passing the encoded url and sometimes Publisher are passing encoded url in the referrer parameter. This fix is a protection in case a module is update and start passing encode url. Our AE is not decoding and from some test I did, monetisation could be highly impacted. * Update rubiconBidAdapter.js * Update rubiconBidAdapter_spec.js * Update rubiconBidAdapter_spec.js * Update rubiconBidAdapter_spec.js * Update rubiconBidAdapter_spec.js * Update rubiconBidAdapter_spec.js * Update rubiconBidAdapter_spec.js * Update rubiconBidAdapter.js * Update rubiconBidAdapter.js * Update rubiconBidAdapter_spec.js * Update rubiconBidAdapter.js * Update rubiconBidAdapter_spec.js * Update rubiconBidAdapter_spec.js

Antoine Jacquemin (Rubicon) added 2 commits September 13, 2018 16:25

Update rubiconBidAdapter.js

9c02d11

jsnellbaker requested a review from idettman September 13, 2018 12:53

jsnellbaker assigned idettman Sep 13, 2018

jsnellbaker added the needs review label Sep 13, 2018

bretg changed the title ~~DecodeUrl if url is encoded~~ Rubicon adapter: DecodeUrl if url is encoded Sep 13, 2018

Antoine Jacquemin (Rubicon) added 9 commits September 14, 2018 12:02

Update rubiconBidAdapter_spec.js

73d44e7

Update rubiconBidAdapter_spec.js

d3786ba

Update rubiconBidAdapter_spec.js

e05c0fe

Update rubiconBidAdapter_spec.js

5f90bc3

Update rubiconBidAdapter_spec.js

7982ede

Update rubiconBidAdapter_spec.js

903561a

Update rubiconBidAdapter.js

d530010

Update rubiconBidAdapter.js

53157ec

Update rubiconBidAdapter_spec.js

c3bc54d

harpere reviewed Sep 14, 2018

View reviewed changes

harpere approved these changes Sep 18, 2018

View reviewed changes

harpere added question reviewed and removed needs review labels Sep 18, 2018

bretg removed the request for review from idettman September 19, 2018 17:50

bretg unassigned idettman Sep 19, 2018

bretg assigned mkendall07 Sep 19, 2018

mkendall07 requested changes Sep 19, 2018

View reviewed changes

bretg closed this Sep 26, 2018

bretg reopened this Sep 27, 2018

Antoine Jacquemin (Rubicon) added 3 commits September 28, 2018 13:27

Update rubiconBidAdapter.js

8d0030e

Update rubiconBidAdapter_spec.js

2eef85e

Update rubiconBidAdapter_spec.js

80435b1

harpere approved these changes Sep 28, 2018

View reviewed changes

harpere added LGTM and removed question reviewed labels Sep 28, 2018

harpere changed the title ~~Rubicon adapter: DecodeUrl if url is encoded~~ Rubicon adapter: get referrer from bidderRequest.refererInfo.referer; Sep 28, 2018

harpere merged commit ee1cd7e into prebid:master Sep 28, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rubicon adapter: get referrer from bidderRequest.refererInfo.referer; #3087

Rubicon adapter: get referrer from bidderRequest.refererInfo.referer; #3087

AntoineJac commented Sep 13, 2018

mkendall07 commented Sep 13, 2018

AntoineJac commented Sep 14, 2018

harpere Sep 14, 2018

mkendall07 Sep 14, 2018

AntoineJac Sep 18, 2018

harpere Sep 18, 2018 •

edited

Loading

bretg commented Sep 19, 2018

mkendall07 commented Sep 19, 2018 •

edited

Loading

mkendall07 left a comment

bretg commented Sep 26, 2018

bretg commented Sep 27, 2018

AntoineJac commented Sep 28, 2018

Rubicon adapter: get referrer from bidderRequest.refererInfo.referer; #3087

Rubicon adapter: get referrer from bidderRequest.refererInfo.referer; #3087

Conversation

AntoineJac commented Sep 13, 2018

Type of change

Description of change

Other information

mkendall07 commented Sep 13, 2018

AntoineJac commented Sep 14, 2018

harpere Sep 14, 2018

Choose a reason for hiding this comment

mkendall07 Sep 14, 2018

Choose a reason for hiding this comment

AntoineJac Sep 18, 2018

Choose a reason for hiding this comment

harpere Sep 18, 2018 • edited Loading

Choose a reason for hiding this comment

bretg commented Sep 19, 2018

mkendall07 commented Sep 19, 2018 • edited Loading

mkendall07 left a comment

Choose a reason for hiding this comment

bretg commented Sep 26, 2018

bretg commented Sep 27, 2018

AntoineJac commented Sep 28, 2018

harpere Sep 18, 2018 •

edited

Loading

mkendall07 commented Sep 19, 2018 •

edited

Loading