Add referer detection module #3067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnellbaker
requested changes
Sep 11, 2018
src/refererDetection.js
Outdated
| location: null, | ||
| isTop: (currentWindow == win.top) | ||
| }); | ||
| logError('Error while accessing cross domain iframe.', e); |
There was a problem hiding this comment.
Does this need to be a logError? Based on my testing in a cross domain testpage in Chrome, the data still gets collected (due to available information in ancestor) but it also displays this error.
Should it be a warning instead perhaps?
mkendall07
reviewed
Sep 11, 2018
src/refererDetection.js
Outdated
| stack: stackInfo.stack, | ||
| }; | ||
| } catch (e) { | ||
| logError('Error while getting referer info', e); |
There was a problem hiding this comment.
we probably don't need to log any errors from this module since it doesn't alter any behavior if something breaks. Bump down to warn or message.
mkendall07
approved these changes
Sep 11, 2018
This was referenced Sep 13, 2018
10 tasks
ptomasroos
pushed a commit
to happypancake/Prebid.js
that referenced
this pull request
Sep 25, 2018
* add referere detection module * dont log all errors on console * Update message * Add jsdoc
StefanWallin
pushed a commit
to mittmedia/Prebid.js
that referenced
this pull request
Sep 28, 2018
* add referere detection module * dont log all errors on console * Update message * Add jsdoc
SublimeJeremy
pushed a commit
to SublimeSkinz/Prebid.js
that referenced
this pull request
Oct 1, 2018
* add referere detection module * dont log all errors on console * Update message * Add jsdoc
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
* add referere detection module * dont log all errors on console * Update message * Add jsdoc
pedrolopezmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Mar 18, 2019
* add referere detection module * dont log all errors on console * Update message * Add jsdoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This PR adds referer detection module to prebid core. New property
refererInfois added to bidderRequest object.Following details will be available to each bidder
All bidders can access this info in buildRequests spec.
We will be deprecating
utils.getTopWindowLocationandutils.getTopFrameReferrersoon.