Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trafficroots Bid Adapter Submission #2993

Merged
merged 3 commits into from
Sep 25, 2018
Merged

Trafficroots Bid Adapter Submission #2993

merged 3 commits into from
Sep 25, 2018

Conversation

cary67
Copy link
Contributor

@cary67 cary67 commented Aug 19, 2018

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Trafficroots bid adapter initial submission

  • test parameters for validating bids
{
  bidder: 'trafficroots',
  params: {
      zoneId: 'aa0444af31',
      deliveryUrl: 'https://service.trafficroots.com/prebid'
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@snapwich snapwich assigned snapwich and idettman and unassigned snapwich Aug 20, 2018
@snapwich snapwich requested a review from idettman August 20, 2018 15:35
@bretg
Copy link
Collaborator

bretg commented Aug 20, 2018

Docs PR prebid/prebid.github.io#936

@stale
Copy link

stale bot commented Sep 3, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 3, 2018
@stale stale bot closed this Sep 10, 2018
@bretg bretg reopened this Sep 10, 2018
@stale stale bot removed the stale label Sep 10, 2018
@bretg bretg added the pinned won't be closed by stalebot label Sep 10, 2018
@mkendall07
Copy link
Member

@idettman ping for review

Copy link
Contributor

@idettman idettman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Copy link
Contributor

@idettman idettman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me, and circleci error is Cannot load browser "bs_ie_14_windows_10"! Error: Username is required. and not code related

@idettman idettman merged commit 726d0a4 into prebid:master Sep 25, 2018
idettman added a commit that referenced this pull request Sep 25, 2018
@idettman
Copy link
Contributor

@cary67 This PR was merged but had an error from the includes method call. Can you create another PR for this branch?

mkendall07 pushed a commit that referenced this pull request Sep 25, 2018
ArmandChoy pushed a commit to RockYou-Ads/Prebid.js that referenced this pull request Sep 28, 2018
* 'master' of https://github.com/prebid/Prebid.js: (367 commits)
  Rubicon adapter: get referrer from bidderRequest.refererInfo.referer; (prebid#3087)
  Minor freewheel-ssp update (prebid#3119)
  fixes prebid#3128 YieldlabBidAdapter is not using bidRequest.params.adSize (prebid#3129)
  Support Video Renderer (prebid#3104)
  Fix for Issue 3130: passing new copy of adUnits object to every adapter (prebid#3131)
  Add video params to Beachfront adapter (prebid#3121)
  Sonobi - Fix ref encoding (prebid#3125)
  update circleci link to just Prebid.js builds (prebid#3132)
  Bugfix: Issue 3111 (prebid#3122)
  increment prebid version
  Prebid 1.25.0 Release
  adding account to s2s bidder-sync request (prebid#3123)
  Revert "Trafficroots Bid Adapter Submission (prebid#2993)" (prebid#3124)
  Trafficroots Bid Adapter Submission (prebid#2993)
  add versioning and deprecation policy doc (prebid#3103)
  improving kargo unit tests for currency handling (prebid#3106)
  AdOcean adapter improvment (prebid#3011)
  Serverbid Bid Adapter: Add pubnx alias (prebid#3064)
  Adds an id parameter (prebid#3107)
  added sizes for rubicon (prebid#3094)
  ...
pedrolopezmrf pushed a commit to Marfeel/Prebid.js that referenced this pull request Mar 18, 2019
* Trafficroots bid adapter submission.  Thank you!

* unit test

* typo fix
pedrolopezmrf pushed a commit to Marfeel/Prebid.js that referenced this pull request Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pinned won't be closed by stalebot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants