-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds an id parameter #3107
Merged
Merged
Adds an id parameter #3107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susyt
force-pushed
the
gumgum-adds-jcsi
branch
from
September 20, 2018 01:09
001febf
to
552f6fc
Compare
This pull request introduces 1 alert when merging 654dc29 into 1b97d55 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
susyt
force-pushed
the
gumgum-adds-jcsi
branch
from
September 20, 2018 01:27
654dc29
to
58bfaf5
Compare
susyt
force-pushed
the
gumgum-adds-jcsi
branch
from
September 20, 2018 02:42
58bfaf5
to
5002b17
Compare
susyt
force-pushed
the
gumgum-adds-jcsi
branch
from
September 20, 2018 18:23
62132f4
to
fa67535
Compare
idettman
approved these changes
Sep 24, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
ptomasroos
pushed a commit
to happypancake/Prebid.js
that referenced
this pull request
Sep 25, 2018
* adds jcsi param * adds try catch
StefanWallin
pushed a commit
to mittmedia/Prebid.js
that referenced
this pull request
Sep 28, 2018
* adds jcsi param * adds try catch
ArmandChoy
pushed a commit
to RockYou-Ads/Prebid.js
that referenced
this pull request
Sep 28, 2018
* 'master' of https://github.com/prebid/Prebid.js: (367 commits) Rubicon adapter: get referrer from bidderRequest.refererInfo.referer; (prebid#3087) Minor freewheel-ssp update (prebid#3119) fixes prebid#3128 YieldlabBidAdapter is not using bidRequest.params.adSize (prebid#3129) Support Video Renderer (prebid#3104) Fix for Issue 3130: passing new copy of adUnits object to every adapter (prebid#3131) Add video params to Beachfront adapter (prebid#3121) Sonobi - Fix ref encoding (prebid#3125) update circleci link to just Prebid.js builds (prebid#3132) Bugfix: Issue 3111 (prebid#3122) increment prebid version Prebid 1.25.0 Release adding account to s2s bidder-sync request (prebid#3123) Revert "Trafficroots Bid Adapter Submission (prebid#2993)" (prebid#3124) Trafficroots Bid Adapter Submission (prebid#2993) add versioning and deprecation policy doc (prebid#3103) improving kargo unit tests for currency handling (prebid#3106) AdOcean adapter improvment (prebid#3011) Serverbid Bid Adapter: Add pubnx alias (prebid#3064) Adds an id parameter (prebid#3107) added sizes for rubicon (prebid#3094) ...
SublimeJeremy
pushed a commit
to SublimeSkinz/Prebid.js
that referenced
this pull request
Oct 1, 2018
* adds jcsi param * adds try catch
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
* adds jcsi param * adds try catch
pedrolopezmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Mar 18, 2019
* adds jcsi param * adds try catch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Adds a jcsi param for reporting purposes
Other information
@mxcoder