Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YieldlabBidAdapter is not using bidRequest.params.adSize as customsize in bidResponse #3128

Closed
vi-oder-was opened this issue Sep 26, 2018 · 2 comments
Closed

YieldlabBidAdapter is not using bidRequest.params.adSize as customsize in bidResponse #3128

vi-oder-was opened this issue Sep 26, 2018 · 2 comments

Comments

@vi-oder-was
Copy link

Type of issue

Bug

Description

The customsize is not used within the bidResponse. Instead it uses the primary size of the array bidRequest.sizes.

Steps to reproduce

see screenshot below

Test page

Expected results

The bidResponse should use the bidRequest.params.adSize as width and height for the response.

Actual results

The bidResponse contains the wrong size and doesn't match to the creativeId for Yieldlab deal. The deal doesn't appear.

Platform details

prebid 1.24.1

Other information

image

Introduced in #3035
derdeka pushed a commit to mairdumont-netletix/Prebid.js that referenced this issue Sep 26, 2018
fixes prebid#3128 YieldlabBidAdapter is not using bidRequest.params.a…
eb6f02c 
…dSize as customsize in bidResponse
@derdeka
Copy link
Contributor

derdeka commented Sep 26, 2018

I've submitted PR #3129 to fix that issue.

derdeka pushed a commit to mairdumont-netletix/Prebid.js that referenced this issue Sep 28, 2018
fixes prebid#3128 YieldlabBidAdapter is not using bidRequest.params.a…
020f27b 
…dSize as customsize in bidResponse - add test
ArmandChoy pushed a commit to RockYou-Ads/Prebid.js that referenced this issue Sep 28, 2018
Merge branch 'master' of https://github.com/prebid/Prebid.js
92997e1 
* 'master' of https://github.com/prebid/Prebid.js: (367 commits)
  Rubicon adapter: get referrer from bidderRequest.refererInfo.referer; (prebid#3087)
  Minor freewheel-ssp update (prebid#3119)
  fixes prebid#3128 YieldlabBidAdapter is not using bidRequest.params.adSize (prebid#3129)
  Support Video Renderer (prebid#3104)
  Fix for Issue 3130: passing new copy of adUnits object to every adapter (prebid#3131)
  Add video params to Beachfront adapter (prebid#3121)
  Sonobi - Fix ref encoding (prebid#3125)
  update circleci link to just Prebid.js builds (prebid#3132)
  Bugfix: Issue 3111 (prebid#3122)
  increment prebid version
  Prebid 1.25.0 Release
  adding account to s2s bidder-sync request (prebid#3123)
  Revert "Trafficroots Bid Adapter Submission (prebid#2993)" (prebid#3124)
  Trafficroots Bid Adapter Submission (prebid#2993)
  add versioning and deprecation policy doc (prebid#3103)
  improving kargo unit tests for currency handling (prebid#3106)
  AdOcean adapter improvment (prebid#3011)
  Serverbid Bid Adapter: Add pubnx alias (prebid#3064)
  Adds an id parameter (prebid#3107)
  added sizes for rubicon (prebid#3094)
  ...
@phtechno
Copy link
Contributor

phtechno commented Oct 2, 2018

Hello everybody,
we need a posibility to handle different adsizes between the adslots and the response. Like "Sitebars" in our case. We have two adslots for "Sitebars" (responsive) and for "HalfpageAds" (300x600). Both have the slot size 300x600, but we can not differentiate if we have no indicator (like adsize) to do that.
Exactly for this case we need this bug as a feature to give the responsive a custom size.

Do you have another suggestion?

pedrolopezmrf pushed a commit to Marfeel/Prebid.js that referenced this issue Mar 18, 2019
@derdeka
fixes prebid#3128 YieldlabBidAdapter is not using bidRequest.params.a…
f6c6a35 
…dSize (prebid#3129)

* fixes prebid#3128 YieldlabBidAdapter is not using bidRequest.params.adSize as customsize in bidResponse

* fixes prebid#3128 YieldlabBidAdapter is not using bidRequest.params.adSize as customsize in bidResponse - add test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@phtechno @derdeka @vi-oder-was