-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔥 Remove more TMC26X #1034
🔥 Remove more TMC26X #1034
Conversation
CI will fail due to a handful of Geeetech configs that still won't build correctly due to some LCD/library incompatibilities after MarlinFirmware/Marlin@ec7ab5a. |
c5e57b7
to
7eb7090
Compare
6abdfe1
to
cc269cd
Compare
...PR fixed after recent force-pushes to |
I'm not sure what process @thinkyhead uses to deploy updated Configuration files across all the examples. This might be something that he has some automation around, or perhaps you are already using the same tools he does? |
Find and replace 💪 …along with a manual check to make sure nothing was missed due to the custom nature of some configs. |
Followup to 4e9493f
cc269cd
to
c985c37
Compare
Rebased on current |
...and apparently some other recent changes: HEAD is now at f5cf667c95 🎨 Clarify some string parameters (#26949)
Building Configurations in config/examples/CNC/miniRambo ...
Building environment rambo for board MINIRAMBO (1201)...
In file included from Marlin/src/gcode/feature/digipot/../../../inc/MarlinConfigPre.h:37:0,
from Marlin/src/gcode/feature/digipot/../../../inc/MarlinConfig.h:28,
from Marlin/src/gcode/feature/digipot/M907-M910.cpp:23:
Marlin/src/gcode/feature/digipot/M907-M910.cpp: In static member function 'static void GcodeSuite::M907_report(bool)':
Marlin/src/gcode/feature/digipot/M907-M910.cpp:137:13: error: 'SP_E_STR' was not declared in this scope
, SP_E_STR, stepper.motor_current_setting[2] // E
^ Edit: This CNC config was committed directly so it was not checked by CI: e7254f1 |
Should now be sorted out by tweaks to Motor Current PWM pin handling. |
Description
Followup to 4e9493f / MarlinFirmware/Marlin#26770
Benefits
Removes dead config options
Related Issues