update PROBE_TEMP_COMPENSATION section to not include float/unsigned identifiers #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
See MarlinFirmware/Marlin#22130
Description
The 'probe_temp_compenation' feature was moved to
celsius_tat some point in the last few months, but the default config was not updated, and users previously using float vals inBTC_SAMPLE_START,BTC_SAMPLE_RES,PTC_SAMPLE_START,PTC_SAMPLE_RES, etc are being met with narrowing conbversion errors that break compilation.Benefits
Fixes up the default config from the replacement of
floatwithcelsius_tin probe_temp_compensation.h, and adds new sanity checks for floats which will warn users with old configs.Related Issues
MarlinFirmware/Marlin#22130
MarlinFirmware/Marlin#22044