-
-
Notifications
You must be signed in to change notification settings - Fork 19.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FR] Make Linear Advance values for Fixed Time Motion more usable.. (say K0.6 instead of K0.000006) #26642
Comments
@ahmetcemturan , as the math for linear advance are different between standard motion and FT_MOTION, no conversion is possible. I will make a PR with M493 reporting the same values as in the menu. |
Regarding TinyBee: Yes I have a MKS TinyBee. |
Have a look at PR #26643. |
Well this port makes the situation even worse now. Now I can't see the actual K value at all, as the number is truncated with two decimals. Regarding TinyBee: I have downloaded and patched your zip. I will try it out as sson as possible.. |
Marlin.zip |
Thank you. You can test the bugfix branch as @thinkyhead has pushed a slightly modified code. |
I tried it but it won't home correctly when FT ia enabled. |
@ahmetcemturan , what are the results for individual homing : G28 X, G28 Y and G28 Z ? Is manual axis movement smooth and fine in X, Y and Z? |
Same |
I can't confirm the error with latest bugfix but my printer is not a corexy. As you can home with |
increase or decrease? |
Increase with |
If the PR #26643 has fully addressed this issue then it can be closed. |
That PR made usability worse: #26642 (comment)
|
It would be better if the precision had been left at 8 or even increased to 10
|
If the value is set with M493 Gcode, the linear advance value sent is the one saved. Thz decimals are only for the menu (alphanumeric). As I said before, If others confirm the K value around 0.000001, we need to change the way it's shown in the menu with consistency between M493 and the menu. |
Are you not uslng Linear Advance yourself?
|
HAve You checked with others? |
Can you write what kind of values You use for K (FT Motion K) |
Please test #26785 and report your findings in that PR. |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Is your feature request related to a problem? Please describe.
Sort of.. It is more difficult to work with these zeros behind the comma. The serial monitor does not display it...
M493 S1 A37.00 B37.00 D0 F0.00 H0.00 P1 K0.00
When I send M493
I get:
Fixed-Time Motion enabled.
Linear Advance enabled. Gain: 0.00001
The Actual value entered is 0.000006
Are you looking for hardware support?
No
Describe the feature you want
It is easier for someone to switch from the old K values to the new ones (especially as the function and the variable name are the same).
A factor of 10000 would be fitting I think..
Also it would be great if the https://marlinfw.org/tools/lin_advance/k-factor.html page had an option for Fixed Time Linear Motion calibration where it would put out M493 instead of M900..
Now that FT Motion works I think that would be very nice
Additional context
Also some clarification whether these two K-factors should or should not be used together would be nice.
The text was updated successfully, but these errors were encountered: