Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store and display FT_MOTION linearadvance as a float with 4 digit and 2 decimals #26785

Merged

Conversation

narno2202
Copy link
Contributor

@narno2202 narno2202 commented Feb 11, 2024

Description

As reported by users, linearadvance value in FT_MOTION is a 10E-6 value. Setting via M493 is correct but the reported value is not correct and is impossible to set via FT_MOTION menu.
With this PR the value is shown and stored as a float with four digit and 2 decimals, the real linearadvance value is processed in ft-motion.cpp .
The menu is updated accordingly.

Requirements

FT_MOTION enbaled

Benefits

Linearadvance value can be et via menu, M493 and reported correctly

Configurations

Related Issues

@grizzleeadam
Copy link

Wanted to give some feedback on this. I've got a pretty much stock Ender 3 Pro (SKR Mini E3 v1.2 board) with the stock bowden tube and have been playing around with FT Motion today (using your FT-Motion Print Menu branch as of 2/17/24)

Using 2500 acceleration, and MZV shaping tuned, my K-factor is best around .024. (Used the Marlin K-factor calibration generator, replaced all the M900 commands with M493.)

Other variables that may have an effect: using JD at .14, edge_stepping on, s-curve on, stealthchop enabled.

I'm not sure if your .000006 value is from a direct drive extruder? Would be good to have the multiplier be fair for both direct drive & bowden setups - maybe a 10e4 multiplier with 2 decimals?

@narno2202
Copy link
Contributor Author

You are the third user reporting a K factor value. So, this is the first range of values. I change the code accordingly.

@narno2202 narno2202 changed the title Store and display FT_MOTION linearadvance as integer Store and display FT_MOTION linearadvance as a float with 4 digit and 2 decimals Mar 3, 2024
@thisiskeithb thisiskeithb added this to the Version 2.1.3 milestone May 17, 2024
@thinkyhead thinkyhead merged commit 9a5f1d2 into MarlinFirmware:bugfix-2.1.x Jul 15, 2024
39 of 62 checks passed
thinkyhead pushed a commit that referenced this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] Make Linear Advance values for Fixed Time Motion more usable.. (say K0.6 instead of K0.000006)
4 participants