-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Marlin Color UI for STM32F1 (FSMC) #18952
Marlin Color UI for STM32F1 (FSMC) #18952
Conversation
@thisiskeithb if you dont mind and have some time, can you test it in the nano v1.2? And do a M995 to calibrate the TFT, to send me the calibration values, so I can make fix the default values? |
eee09a4
to
55f83dd
Compare
Sure thing. I'm working on another project right now, but I should be able to get to testing this weekend. |
Current bugfix-2.0x is failing the CI. |
…default for that boards
Will do a calibration now, but I don't think it fixes this problem :) These values worked with the standard touch UI: // #define XPT2046_X_CALIBRATION 12013 But it doesn't react to touches with the Marlin Color UI Edit: It doesn't react to touches when doing M995. Also tried with #define TOUCH_SCREEN commented out, but then it doesn't show the icons, so I guess it needs to be defined |
WOW! The screen is mirrored! I will take a look about mirroring in the lcd init code. In the pins_MKS_NANO_ROBIN.h, try defining all |
I've commented out the XPT2046 defines in Configuration.h and changed those in pins_MKS_NANO_ROBIN.h to 0, but the touch screen still doesn't react to touch. Neither after booting nor after M995 |
@Miraculix200 can you try this branch? |
@rhapsodyv I've changed the pins file like in the latest commit of your branch. Then the display doesn't start (shows the "Booting..." screen). Printer starts however, can be connected through USB. I'll try with reset pin commented out. Just a random test |
Its the TFT_DRIVER I changed to auto. Try setting back to ILI9488 or ST7796 . |
Ok. Are you sure TOUCH_BUTTONS_HW_SPI is right? Because this is not an SPI display |
Touch is SPI, almost always. Sometimes SW SPI, sometimes HW SPI. |
I'm testing a Nano v2 now |
Still doesn't react to touch. I'll try ST7796 |
hahahah I found the problem!!!! Just a moment. |
Try my branch now. If touch works, we will fix the tft. |
Well, it's calibrating itself instead of waiting for me touching it. I'll try again, but I don't think that's right. It gets touch signals from somewhere else |
Try this branch, I fixed the touch: #18958 |
Try put back it:
|
Oh I didn't see you changed it to device 1. I still got this: #define TFT_DRIVER ILI9488 I'm not using your branch but looking at your commits and then changing my code. I'll try changing it to 1. edit: nvm, was confusing it with robin nano v2 |
Ahhh remove that so. remove it:
In my branch I removed. I was trying things... but the problem was the missing |
Recv: Touch screen calibration completed |
Thanks! I will put it in the defaults. Your TFT is mirrored yet? |
Yes, it's still mirrored. But when it says "top left", I actually touch the top left corner, not the corner where the cursor is |
Ok. Give some minute, I will update my branch with a test for the mirror issue. |
@Miraculix200 try it now in the branch |
That sort of worked. But now it's upside down :D |
Actually it's now mirrored horizontally AND vertically |
Just pushed the last one :-) |
Now it's not mirrored anymore. Can be pushed |
Check if the calibration values changed. I dont think, but is best to check |
Actually M995 doesn't work anymore now. Says "calibration failed" after touching the 4 corners. I'll compile it again with the values I found during the previous calibration |
Try with a pen. Its very sensible :-/ |
That worked. Got different values now: Recv: TOUCH_CALIBRATION_X 17880 And now my touch screen probably has Covid-19 :D |
Thanks!!! |
Description
Democratization of Marlin UIs!!
This is a port of the new Marlin Color UI for STM32F1. Currently FSMC support.
Added support for Chitu and MKS Robin Nano v1.
I will send more two separated PR in the next days. One for SPI (is almost complete) and other that will centralize all TFT IO/XPT for STM32F1: All FSMC and SPI UI will use (LVGL, emulated dogm, color UI).
Benefits
More users will be able to use the new Marlin Color UI.
Related Issues