-
-
Notifications
You must be signed in to change notification settings - Fork 19.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change XY_PROBE_SPEED format to (x*60) #18997
Conversation
Changing XY_PROBE_SPEED value format to match the other mm/m formats in the configurations.
The "natural" unit for feedrates is the mm/m value used with the |
My idea was to use the same format for If we’re already here, may I ask why |
For historical and (backward) compatibility reasons we have to use mm/minute for the F-parameter. (maybe inch/minute in inch-mode). For the average feedrates used in early CNC-machines that made perfect sense. Adjusting by g-code is much less satisfying - we can't calculate but only read numbers. On the long term a calculating parser could be useful.
Internal representation should stay in mm/s. |
For the derived units, like accelerations, mm/minute becomes really ugly. I would not like to see mm/minute² |
Yeah, a uniformity of IMO, the ideal option would be at first
then in the distant future to have it as
with a legacy option in the configurations to have the F parameter in mm/m. |
mm/m is millimetre/meter = 1000. Always! |
I think mm/m is short for mm/min in the configurations. |
Then take it as an error-report. |
… into bugfix-2.0.x * 'bugfix-2.0.x' of https://github.com/MarlinFirmware/Marlin: (33 commits) Minor cleanup w/r/t LEDs TFT32 for MKS Robin Nano 1.2 (MarlinFirmware#19031) [cron] Bump distribution date (2020-08-24) Feedrate comment (MarlinFirmware#19116) Neopixel => NeoPixel Fix up conditions, comments Fix DUET_SMART_EFFECTOR Consistent static/value item macros [cron] Bump distribution date (2020-08-23) Fix probing margin sanity-check PGMSTR constexpr => const NOZZLE_CLEAN_NO_Y (MarlinFirmware#18870) Change XY_PROBE_SPEED format to (x*60) (MarlinFirmware#18997) Reformat pins files Permit ST7789V orientation override (MarlinFirmware#19044) Prefer Servo AVR timer4 over 3 (MarlinFirmware#19025) DIGIPOT_I2C pins for SMOOTHIEBOARD (MarlinFirmware#19098) Translatable strings on Ender-3 V2 DWIN (MarlinFirmware#19053) HIGH/LOW naming of pin state settings (MarlinFirmware#19089) Update copy_marlin_variant_to_framework.py ...
Description
Changing
XY_PROBE_SPEED
value format to match the other mm/m feedrate formats in the configurations.Benefits
Feedrate format uniformity.
Related Issues
None