Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TFT32 screen support on MKS Robin Nano 1.2 board #19031

Merged
merged 4 commits into from
Aug 24, 2020
Merged

TFT32 screen support on MKS Robin Nano 1.2 board #19031

merged 4 commits into from
Aug 24, 2020

Conversation

alexeyzel
Copy link
Contributor

Description

MKS Robin Nano 1.2. Board can come with TFT32 screen based on ILI9341, for example on Flsun Q5 3d printer. This changes in pins_MKS_ROBIN_NANO.h file will make new style UI work with this board with TFT32 screen. It will work if #define TFT_320x240 is selected in configutation.h and board type is #define MOTHERBOARD BOARD_MKS_ROBIN_NANO

Benefits

An ability to use sew style UI on MKS Robin Nano 1.2 Board with TFT32 screen (320x240 screen resolution).

Related Issues

@mmajoor
Copy link
Contributor

mmajoor commented Aug 17, 2020

I think TFT_DRIVER and ILI9341_ORIENTATION, and simular settings, should not be defined in this pins_MKS_ROBIN_NANO.h file but instead in configuration.h or configuration_adv.h if possible (there is already a TFT_DRIVER define in configuration.h).
The main reason is that it assumes that all 320x240 displays are created equal and that is not the case.
In my case, I also have a Q5 printer with a 320x240 display, but this one uses a ST7789V display driver. It is a 'Makerbase MKS TFT24 V1.0' (but -not- the one you willl find on the MakerBase GitHub repositories - it is a simplified version without STM32 CPU).
In my case I did not need to define the TFT_DRIVER setting at all (by default set to AUTO). I did need to rotate the display.

alexeyzel and others added 3 commits August 22, 2020 01:23
MKS Robin Nano 1.2. Board can come with TFT32 screen based on ILI9341, for example on Flsun Q5 3d printer. This changes in pins_MKS_ROBIN_NANO.h file will make new style UI work with this board with TFT32 screen. It will work if #define TFT_320x240 is selected in configutation.h and board type is #define MOTHERBOARD BOARD_MKS_ROBIN_NANO
@thinkyhead
Copy link
Member

I kind of went the other way, where if TFT_DRIVER isn't defined as AUTO then the type is chosen based on the clues from the pins files. This probably should get a review from @rhapsodyv and other interested TFT integrators.

@rhapsodyv
Copy link
Sponsor Member

I kind of went the other way, where if TFT_DRIVER isn't defined as AUTO then the type is chosen based on the clues from the pins files. This probably should get a review from @rhapsodyv and other interested TFT integrators.

Sure, I think the same. We are trying to add defaults TFT configs to every board that we can test. Maybe sometimes we forget the #ifndef to make it overwritable, but the purpose is to have the most common TFT config ready to be used. It is easier for the user get started.

In the last weeks we received a lot of TFT support. Now that everything looks like stable, we are working in some refactoring, removing old and duplicated code, and changing some configs to make it easier for the user.

In a week or so, I think every option for those 3 new UI will be supported for all TFT.

@rhapsodyv
Copy link
Sponsor Member

I have added I few reviews. I think this PR must be only about add support for TFT32 in nano v1.2. And keep the code about TFT35 as it was, because it's already tested and working.
TFT35 and TFT32 can't conflict with each other in the code, because they have different init codes, and is needed different defines to setup each one.

This reverts commit ee81a59.
@thinkyhead thinkyhead merged commit 4b12435 into MarlinFirmware:bugfix-2.0.x Aug 24, 2020
susisstrolch pushed a commit to susisstrolch/Marlin that referenced this pull request Aug 24, 2020
… into bugfix-2.0.x

* 'bugfix-2.0.x' of https://github.com/MarlinFirmware/Marlin: (33 commits)
  Minor cleanup w/r/t LEDs
  TFT32 for MKS Robin Nano 1.2 (MarlinFirmware#19031)
  [cron] Bump distribution date (2020-08-24)
  Feedrate comment (MarlinFirmware#19116)
  Neopixel => NeoPixel
  Fix up conditions, comments
  Fix DUET_SMART_EFFECTOR
  Consistent static/value item macros
  [cron] Bump distribution date (2020-08-23)
  Fix probing margin sanity-check
  PGMSTR constexpr => const
  NOZZLE_CLEAN_NO_Y (MarlinFirmware#18870)
  Change XY_PROBE_SPEED format to (x*60) (MarlinFirmware#18997)
  Reformat pins files
  Permit ST7789V orientation override (MarlinFirmware#19044)
  Prefer Servo AVR timer4 over 3 (MarlinFirmware#19025)
  DIGIPOT_I2C pins for SMOOTHIEBOARD (MarlinFirmware#19098)
  Translatable strings on Ender-3 V2 DWIN (MarlinFirmware#19053)
  HIGH/LOW naming of pin state settings (MarlinFirmware#19089)
  Update copy_marlin_variant_to_framework.py
  ...
albertogg pushed a commit to albertogg/Marlin that referenced this pull request Aug 31, 2020
thinkyhead pushed a commit to thinkyhead/Marlin that referenced this pull request Sep 2, 2020
vgadreau pushed a commit to vgadreau/Marlin that referenced this pull request Dec 9, 2020
kageurufu pushed a commit to CR30-Users/Marlin-CR30 that referenced this pull request Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants