fix for #19224 for independent neopixel strip control option not being separated #19250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bugfix 2.0.x
sorry im not a programer but i did my best to get 2 seperated controls for extra visual indiaction from the LEDS by keeping the Printer Events on the main channel .
Originally labeled as DUET_SMART_EFFECTOR but this is incorrect as MarlinCore looks for SMART_EFFECTOR and not DUET_SMART_EFFECTOR
for some reason NEOPIXEL_SEPERATE ended up missing in config
trying out stuffs
with NeoPixel2_separate enabled there isnt a conflict if they are different Neo type
i dont know why i thought this was needed if neopixel is't enabled then there wont be a neopixel2
M150 S1 I1 R ; Set SEPARATE index 1 to red
moved the CONJOINED_NEOPIXEL from Conditionals_LCD.h to neopixel.h because MULTIPLE_NEOPIXEL_TYPE wouldnt trip the trigger in conditionals
adaneo1 still was set to NEOPIXEL2_PIN and was bleeding into the separated neopixel bank during start up and regular M150 commands found that adaneo never set a pin once NEOPIXEL2_SEPARATE is enabled
TERN_(NEOPIXEL2_SEPARATE,,adaneo1.setPin(NEOPIXEL2_PIN)); dosent compile as is. i believe it has an extra comma in it
TERN_(NEOPIXEL2_SEPARATE,adaneo1.setPin(NEOPIXEL2_PIN)); stops NEOPIXEL2_SEPARATE From working as intended it bleeds into the separate channel #if Disabled(NEOPIXEL2_SEPARATE) Works like its supposed to is there a different macro than TERN_(NEOPIXEL2_SEPARATE,adaneo1.setPin(NEOPIXEL2_PIN)); becuase it dosnet have the desired effect
Bacon-Fixation
changed the title
Bacon-Fixation
changed the title
vgadreau
pushed a commit
to vgadreau/Marlin
that referenced
this pull request
Dec 9, 2020
kageurufu
pushed a commit
to CR30-Users/Marlin-CR30
that referenced
this pull request
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TERN_(NEOPIXEL2_SEPARATE,adaneo1.setPin(NEOPIXEL2_PIN));stops NEOPIXEL2_SEPARATE From working as intended, It is bleeding into the separate channel.Problems with this macro:
But with the
#if DISABLED(NEOPIXEL2_SEPARATE)it works like it is supposed to.is there a different macro other than
TERN_(NEOPIXEL2_SEPARATE,adaneo1.setPin(NEOPIXEL2_PIN));?because it doesn't have the desired effect.
I apologize, I made an assumption and didn't have the opportunity to test #19224 on my equipment until today.
Related Issues
#19224 - bug NEOPIXEL2_SEPARATE with TERN_(NEOPIXEL2_SEPARATE,adaneo1.setPin(NEOPIXEL2_PIN));