[WIP] Makefile patches #19633
Closed
[WIP] Makefile patches #19633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change the default board to BOARD_RAMPS_14_EFB (1020) in the Makefile to avoid
the following error message on a clean build (no variables given to make):
src/pins/pins.h:743:6: error: \#error "Unknown MOTHERBOARD value set in Configuration.h"
\#error "Unknown MOTHERBOARD value set in Configuration.h"
^
Disable these two libraries because they're not provided with Arduino nor Marlin by default, so a no-arguments `make` simply fails.
Tone.cpp (from ADRUINO_DIR/hardware/arduino/avr/cores/arduino/) is required when the speaker function is enabled. Otherwise, the linker complains: applet/src/libs/buzzer.o: In function `Buzzer::tick()': buzzer.cpp:(.text._ZN6Buzzer4tickEv+0xb2): undefined reference to `tone(unsigned char, unsigned int, unsigned long)' collect2: error: ld returned 1 exit status
Most of the time, CC resolves to avr-gcc, which is the C compiler, and hence won't be able to properly link C++ objects (It won't pass the proper flags to the linker). So use CXX instead.
|
Thanks for your contribution! Unfortunately we can't accept PRs directed at release branches. We make patches to the bugfix branches and only later do we push them out as releases. Please redo this PR starting with the It may help to set your fork's default branch to See Marlin's Contributing Code with Pull Requests guide for full instructions. |
|
Ooops, my bad :x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Building Marlin without the Arduino IDE
Description
Multiple fixes on the Makefile, so Marlin can be properly built without the Arduino IDE
(i.e, only with the core(s) and the source files)
Benefits
Related Issues
None found