Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Makefile patches #19633

Closed
wants to merge 6 commits into from
Closed

[WIP] Makefile patches #19633

wants to merge 6 commits into from

Commits on Oct 6, 2020

  1. Makefile: Change the default board id to match Configuration.h 

    change the default board to BOARD_RAMPS_14_EFB (1020) in the Makefile to avoid
the following error message on a clean build (no variables given to make):

src/pins/pins.h:743:6: error: \#error "Unknown MOTHERBOARD value set in Configuration.h"
     \#error "Unknown MOTHERBOARD value set in Configuration.h"
      ^
    @SamantazFox
    SamantazFox committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    323b9ea View commit details
    Browse the repository at this point in the history

  2. Makefile: disable U8GLIB and TMC libraries 

    Disable these two libraries because they're not provided with Arduino nor Marlin
by default, so a no-arguments `make` simply fails.
    @SamantazFox
    SamantazFox committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    f0cb91e View commit details
    Browse the repository at this point in the history

  3. Makefile: Fix some libraries paths added to VPATH

    @SamantazFox
    SamantazFox committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    a2a154a View commit details
    Browse the repository at this point in the history

  4. Makefile: Add Tone.cpp to the CXX source files 

    Tone.cpp (from ADRUINO_DIR/hardware/arduino/avr/cores/arduino/) is required when
the speaker function is enabled. Otherwise, the linker complains:

applet/src/libs/buzzer.o: In function `Buzzer::tick()':
buzzer.cpp:(.text._ZN6Buzzer4tickEv+0xb2): undefined reference to
	`tone(unsigned char, unsigned int, unsigned long)'
collect2: error: ld returned 1 exit status
    @SamantazFox
    SamantazFox committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    ed85c0a View commit details
    Browse the repository at this point in the history

  5. Makefile: formating, wrap long lines when possible

    @SamantazFox
    SamantazFox committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    efbcf91 View commit details
    Browse the repository at this point in the history

  6. Makefile: Use CXX to build .elf target 

    Most of the time, CC resolves to avr-gcc, which is the C compiler, and hence
won't be able to properly link C++ objects (It won't pass the proper flags to
the linker). So use CXX instead.
    @SamantazFox
    SamantazFox committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    b270a4c View commit details
    Browse the repository at this point in the history