MarlinSPI part 1 #19989
Merged
MarlinSPI part 1 #19989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhapsodyv
force-pushed
the
marlin-spi-part-1
branch
2 times, most recently
from
66465b5 to
7cce068
Compare
rhapsodyv
force-pushed
the
marlin-spi-part-1
branch
from
7cce068 to
a07cfaf
Compare
rhapsodyv
force-pushed
the
marlin-spi-part-1
branch
from
66110d9 to
09ac735
Compare
thinkyhead
added
C: Optimization
PR: General Cleanup
PR: Improvement
T: HAL & APIs
thinkyhead
force-pushed
the
marlin-spi-part-1
branch
2 times, most recently
from
b25fa3d to
b5bc89e
Compare
FhlostonParadise
pushed a commit
to FhlostonParadise/Marlin
that referenced
this pull request
Nov 21, 2020
vgadreau
pushed a commit
to vgadreau/Marlin
that referenced
this pull request
Dec 9, 2020
tharts
pushed a commit
to tharts/Marlin
that referenced
this pull request
Jan 6, 2021
dpreed
pushed a commit
to dpreed/Marlin_2.0.x
that referenced
this pull request
Feb 5, 2021
kpishere
pushed a commit
to kpishere/Marlin
that referenced
this pull request
Feb 19, 2021
W4tel-BiDi
pushed a commit
to W4tel-BiDi/Marlin
that referenced
this pull request
Apr 5, 2021
chrisjenda
pushed a commit
to chrisjenda/Marlin
that referenced
this pull request
Apr 5, 2021
chrisjenda
pushed a commit
to chrisjenda/Marlin
that referenced
this pull request
Apr 7, 2021
thinkyhead
pushed a commit
to thinkyhead/Marlin
that referenced
this pull request
Apr 28, 2021
thinkyhead
pushed a commit
to thinkyhead/Marlin
that referenced
this pull request
Apr 29, 2021
thinkyhead
pushed a commit
that referenced
this pull request
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Marlin currently needs 3 SPI class:
SPIClass:
This class normally is provide by the frameworks and have semi default interface.
We need this, because some libs reference it globally.
STM32F1 and LPC fully implements that class. But STM32 have this class provided by stm32duino.
SPISettings:
Hold spi configs for the SPIClass. Same problem about: lib may reference it globally.
MarlinSPI:
As those two classes are often provided by frameworks, we cannot alter it to add some
useful methods for marlin (like DMA transfers).
This is the reason, we need MarlinSPI. It provide the default SPIClass interface, plus some marlin goods.
This is the first version of that. The goal here is to have a full MarlinSPI class for STM32 and only one working code using it. This will fix compilation of W25QXXFlash for STM32.
My next step will be change its interface and to a more advanced use for TFT code, support async/sync.
Benefits
The start of MarlinSPI refactoring.