-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Fan class #24092
Open
thinkyhead
wants to merge
1
commit into
MarlinFirmware:bugfix-2.1.x
Choose a base branch
from
thinkyhead:bf2_fan_refactor_PR
base: bugfix-2.1.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
♻️ Fan class #24092
thinkyhead
wants to merge
1
commit into
MarlinFirmware:bugfix-2.1.x
from
thinkyhead:bf2_fan_refactor_PR
+491
−491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkyhead
added
PR: Coding Standards
T: Development
Makefiles, PlatformIO, Python scripts, etc.
C: Peripherals
C: Temperatures
labels
Apr 26, 2022
thinkyhead
force-pushed
the
bf2_fan_refactor_PR
branch
17 times, most recently
from
April 30, 2022 16:54
ebe810a
to
9071cd0
Compare
thinkyhead
force-pushed
the
bf2_fan_refactor_PR
branch
2 times, most recently
from
May 19, 2022 15:41
046d6b7
to
9c62378
Compare
thinkyhead
force-pushed
the
bf2_fan_refactor_PR
branch
from
May 28, 2022 22:47
9c62378
to
513cac1
Compare
thinkyhead
force-pushed
the
bf2_fan_refactor_PR
branch
from
June 4, 2022 06:35
513cac1
to
ba11b20
Compare
thinkyhead
force-pushed
the
bf2_fan_refactor_PR
branch
3 times, most recently
from
June 23, 2023 09:59
ab2388a
to
de29ca2
Compare
thinkyhead
force-pushed
the
bf2_fan_refactor_PR
branch
from
August 3, 2023 05:37
de29ca2
to
337f1fa
Compare
thinkyhead
force-pushed
the
bf2_fan_refactor_PR
branch
from
August 20, 2023 17:27
337f1fa
to
7ef0802
Compare
thinkyhead
force-pushed
the
bf2_fan_refactor_PR
branch
from
October 25, 2023 22:59
7ef0802
to
9b2749d
Compare
thinkyhead
force-pushed
the
bf2_fan_refactor_PR
branch
2 times, most recently
from
December 24, 2023 23:21
0296fe5
to
f781eb4
Compare
thinkyhead
force-pushed
the
bf2_fan_refactor_PR
branch
from
December 29, 2023 01:50
f781eb4
to
5b5daaf
Compare
thinkyhead
force-pushed
the
bugfix-2.1.x
branch
from
December 30, 2023 11:08
c624e13
to
e6f1b07
Compare
thinkyhead
force-pushed
the
bf2_fan_refactor_PR
branch
3 times, most recently
from
January 22, 2024 22:36
5b34c0f
to
6f05552
Compare
thinkyhead
force-pushed
the
bugfix-2.1.x
branch
2 times, most recently
from
January 26, 2024 00:13
9c65146
to
4f65466
Compare
thinkyhead
force-pushed
the
bf2_fan_refactor_PR
branch
from
January 26, 2024 20:44
6f05552
to
3d32ec9
Compare
thinkyhead
force-pushed
the
bf2_fan_refactor_PR
branch
2 times, most recently
from
May 7, 2024 00:24
1b320db
to
8683295
Compare
thinkyhead
force-pushed
the
bugfix-2.1.x
branch
from
August 12, 2024 01:01
c792921
to
37fb26b
Compare
thinkyhead
force-pushed
the
bf2_fan_refactor_PR
branch
from
September 10, 2024 08:53
8683295
to
349bad1
Compare
thinkyhead
force-pushed
the
bf2_fan_refactor_PR
branch
2 times, most recently
from
September 22, 2024 23:17
9e4ffd6
to
967d637
Compare
thinkyhead
force-pushed
the
bugfix-2.1.x
branch
3 times, most recently
from
September 28, 2024 01:10
37d77d6
to
aa44542
Compare
thinkyhead
force-pushed
the
bf2_fan_refactor_PR
branch
from
September 28, 2024 02:36
967d637
to
6037b24
Compare
thinkyhead
force-pushed
the
bf2_fan_refactor_PR
branch
from
December 1, 2024 02:04
6037b24
to
74d0d4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C: Peripherals
C: Temperatures
Needs: Work
More work is needed
PR: Coding Standards
T: Development
Makefiles, PlatformIO, Python scripts, etc.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor fans, consolidating all common hotend fan code in a simple class.
Mostly there. The
sync_fan_speeds
andkickstart_fan
routines need some updates. More fan-oriented things may be moved tofans.h
/fans.cpp
as this develops.