Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kick start to extruder auto fans #26581

Conversation

Bob-the-Kuhn
Copy link
Contributor

This PR extends the kick start function/feature to the extruder auto fan(s).

This is done by creating a structure that uses the variable kick_active to keep track of the fan state and the variable kick_end to track the time remaining in the kick period. kick_active's tracking duplicates the fanState variable and adds the kick state.

  fanState = {off, on}
  kick_active = {off, kick, on}

There are two logic changes in temperature.cpp:

  • state transitions for the variable kick_active
  • additional versions of the _AUTOFAN_SPEED() macro that incorporate the kick power setting

TESTING
A simple two extruder system was tested on a STM32F446 based BTT Octopus V1.1

OPEN ITEMS

  • Look at if the variable f or the variable realFan should be used to index the new structure. On my simple two extruder system they're always the same.

thinkyhead added a commit to MarlinFirmware/Configurations that referenced this pull request Dec 29, 2023
@thinkyhead
Copy link
Member

Reminder: PR #24092 is still pending If you like messing with fan kickstarts, the only thing holding up that PR is implementing the kickstart. I was aiming to save RAM and to prevent the class from using more memory or flash than the existing fan code, and I haven't revisited it in a while due to other business. It would be good to finish that PR and then we won't have to implement a separate block of kickstart code for every future fan that needs a kickstart feature.

@Bob-the-Kuhn
Copy link
Contributor Author

@thinkyhead - I like your idea of a unified approach. I'll close this PR and switch to working on PR #24092 as time permits.

@thisiskeithb
Copy link
Member

thisiskeithb commented Jan 19, 2024

This should probably be reverted then: MarlinFirmware/Configurations@16b7191

Edit: See MarlinFirmware/Configurations#1006

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants