Expose TRULY_LARGE_AREA option #25026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding 50 and 100mm moves to menu. Adding Z probe Wizard to Motion menu vs so deep in the config- advanced-offsets menus
Truly large area was never mentioned, changed to force_50_100 and added in config file under bed size for user to enable add notes for user in config fix code for SLIM_LCD so that it will never allow anything larger than 10mm (old default) published change didn't actually disable as intended (from my tests) going to add a new PR later for 250, 500, 750 for the real TRULY large area of >= 1000 as code develops I think a 75% motion option is great, sure the .1 5 and 10mm are good for basics, but adding these larger moves as machines and memory capacity develop will greatly increase user experiance.
|
The hidden option |
|
Yes, but the term truly large area is kind of confusing, it's not truly large unless an axis is actually 1000mm. Force large area makes more sense in a sentence and for programming understanding. Could even be called enable_large_moves under menu options. |
thinkyhead
force-pushed
the
bugfix-2.1.x
branch
from
52a9e5e to
7e60d15
Compare
thinkyhead
added a commit
to MarlinFirmware/Configurations
that referenced
this pull request
Jan 2, 2023
thinkyhead
added a commit
to MarlinFirmware/Configurations
that referenced
this pull request
Jan 2, 2023
thinkyhead
force-pushed
the
bugfix-2.1.x
branch
from
4ac0e16 to
3b0b33a
Compare
thinkyhead
force-pushed
the
bugfix-2.1.x
branch
from
3b0b33a to
8226e66
Compare
thinkyhead
added a commit
to thinkyhead/Marlin
that referenced
this pull request
Feb 22, 2023
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
thinkyhead
added a commit
that referenced
this pull request
Apr 7, 2023
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
thinkyhead
added a commit
that referenced
this pull request
Apr 10, 2023
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
thinkyhead
added a commit
to thinkyhead/Marlin
that referenced
this pull request
May 16, 2023
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
tspiva
pushed a commit
to tspiva/Marlin
that referenced
this pull request
May 25, 2023
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
Andy-Big
pushed a commit
to Andy-Big/Marlin_FB_Reborn
that referenced
this pull request
Jul 2, 2023
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed some code issues, SLIM_LCD didn't actually disable as intended from my tests.
Added user function to enable 50_100 in config.h
Added Notes to config.h for user clarification
Some notes added for future development.
I feel that as machines and memory / boards become larger these moves will help users with calibration and maintenance to machines.
Requirements
No
Benefits
Improves userability with larger moves via menu
Configurations
Related Issues