Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Old Experimental Tags #25238

Merged
merged 5 commits into from
Jan 15, 2023
Merged

Remove Old Experimental Tags #25238

merged 5 commits into from
Jan 15, 2023

Conversation

thisiskeithb
Copy link
Member

@thisiskeithb thisiskeithb commented Jan 13, 2023 •
edited
Loading

Description

Several features in Marlin have been marked as experimental for 5...6...7 years at this point and a common question from users is if they should enable X feature because it's marked as experimental.

So, let's remove some old experimental tags!

Removed / Updated

Remove experimental comment from:

  • ABL_BILINEAR_SUBDIVISION
  • NOZZLE_CLEAN_FEATURE
  • PID_EXTRUSION_SCALING
  • EXPERIMENTAL_I2CBUS

Rename EXPERIMENTAL_I2CBUS to I2CBUS.

Completely remove EXPERIMENTAL_SCURVE so users are free to enable S_CURVE_ACCELERATION with LIN_ADVANCE.

This following tags/features will remain marked as experimental

  • MPCTEMP (even though it works well, this needs wider adoption/testing)
  • THERMAL_PROTECTION_VARIANCE_MONITOR (this feature causes issues on builds with stable temps and I personally do not recommend it)
  • INPUT_SHAPING_X/Y (new, still needs work/testing)
  • MULTI_VOLUME (flash drive support is still buggy in general)
  • INTEGRATED_BABYSTEPPING (even though it works well, this needs wider adoption/testing)
  • EXPERIMENTAL_I2S_LA (new, needs wider adoption/testing)

Benefits

Fewer questions about features being safe to enable.

Related Issues

None. Discussion came up on Discord.

@thisiskeithb
Copy link
Member Author

Configs repo will need to be updated for tests to pass.

@GMagician
Copy link
Contributor

Just a question about S curve and lin_advance. I removed one because of "experimental", since I didn't know where/if something wrong could be caused by the presence of both.
Are there in the wild a lot of people, that you are aware, that use both without issues?
Thanks.

@thisiskeithb
Copy link
Member Author

Are there in the wild a lot of people, that you are aware, that use both without issues?
Thanks.

I haven’t seen reported issues.

I run them together on builds here and have both enabled in my PrusaAIO fork (for users who upgrade their MK3/S printers with 32-bit boards) without issues.

There may have been a time when the two were incompatible initially, but that doesn’t seem to be the case anymore.

@thinkyhead
Copy link
Member

The I2CBUS stuff is meant for developers to experiment, and doesn't do anything useful without added code. So I don't mind continuing to call it "experimental." It would be interesting to see if anyone has applied it to an actual problem.

@thinkyhead thinkyhead force-pushed the pr/remove_old_experimental_tags branch from 946b805 to fae7748 Compare January 15, 2023 09:33
thinkyhead added a commit to MarlinFirmware/Configurations that referenced this pull request Jan 15, 2023
@thinkyhead
📝 No longer experimental
bd022ca 
MarlinFirmware/Marlin#25238
thinkyhead added a commit to MarlinFirmware/Configurations that referenced this pull request Jan 15, 2023
@thinkyhead
📝 No longer experimental
26fa700 
MarlinFirmware/Marlin#25238
@thinkyhead thinkyhead force-pushed the pr/remove_old_experimental_tags branch from fae7748 to 61723c8 Compare January 15, 2023 12:07
@thinkyhead thinkyhead merged commit 212167b into MarlinFirmware:bugfix-2.1.x Jan 15, 2023
@thisiskeithb thisiskeithb deleted the pr/remove_old_experimental_tags branch January 15, 2023 18:33
uBaHoFF added a commit to uBaHoFF/Marlin that referenced this pull request Feb 4, 2023
@uBaHoFF
Squashed commit of the following:
753ae87 
commit 6b17d4a
Merge: 73fa199 218ca05
Author: uBaHoFF <85784399+uBaHoFF@users.noreply.github.com>
Date:   Sat Feb 4 12:40:50 2023 +0200

    Merge branch 'bugfix-2.1.x' into HEVO-BTT-SKR-1.3

commit 218ca05
Author: Victor Oliveira <rhapsodyv@gmail.com>
Date:   Sat Feb 4 05:10:26 2023 -0300

    🧑‍💻 General 'MediaFile' type alias (MarlinFirmware#24424)

commit 08d9cbb
Author: vyacheslav-shubin <shubin-vv@krista.ru>
Date:   Sat Feb 4 10:36:07 2023 +0300

    🧑‍💻 Add SD Card 'hide' method for dev usage (MarlinFirmware#22425)

commit 7c0b465
Author: thinkyhead <thinkyhead@users.noreply.github.com>
Date:   Fri Feb 3 06:06:11 2023 +0000

    [cron] Bump distribution date (2023-02-03)

commit cea176a
Author: Martin Turski <quiret@vfemail.net>
Date:   Fri Feb 3 04:01:22 2023 +0100

    🔨 Fix test build path with spaces (MarlinFirmware#25329)

commit cb7af50
Author: Keith Bennett <13375512+thisiskeithb@users.noreply.github.com>
Date:   Thu Feb 2 17:41:46 2023 -0800

    📝 Fix Z*_ENDSTOP_ADJUSTMENT comments (MarlinFirmware#25295)

commit a80036e
Author: thinkyhead <thinkyhead@users.noreply.github.com>
Date:   Thu Feb 2 00:23:18 2023 +0000

    [cron] Bump distribution date (2023-02-02)

commit 8f11428
Author: kg333 <matthew@kyengineer.com>
Date:   Wed Feb 1 19:02:26 2023 -0500

    📺 Melzi v4 with BTT SKR Mini E3 (MarlinFirmware#25321)

commit 3be967b
Author: Scott Lahteine <thinkyhead@users.noreply.github.com>
Date:   Wed Feb 1 02:19:47 2023 -0600

    🩹 PID / MPC heating followup

    Followup to MarlinFirmware#25314

commit 57a7e28
Author: Bob Kuhn <bob.kuhn@att.net>
Date:   Wed Feb 1 02:43:06 2023 -0600

    🩹 Fix progress DOGM compile error (MarlinFirmware#25319)

commit 64338df
Author: Bob Kuhn <bob.kuhn@att.net>
Date:   Wed Feb 1 01:51:11 2023 -0600

    🔧 Fix SD sorting sanity checks (MarlinFirmware#25318)

commit fbe9237
Author: alexgrach <gav@bmstu.ru>
Date:   Wed Feb 1 10:40:13 2023 +0300

    🐛 Fix TFT touch buttons, button colors (MarlinFirmware#25300)

commit d6f4f24
Author: tombrazier <68918209+tombrazier@users.noreply.github.com>
Date:   Wed Feb 1 07:25:13 2023 +0000

    🩹 Fix PID / MPC heating flags (MarlinFirmware#25314)

    Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>

commit aae103e
Author: thinkyhead <thinkyhead@users.noreply.github.com>
Date:   Wed Feb 1 00:25:54 2023 +0000

    [cron] Bump distribution date (2023-02-01)

commit 738f0a1
Author: Dan Royer <dan@marginallyclever.com>
Date:   Mon Jan 30 22:12:03 2023 -0800

    ✨ POLARGRAPH / PEN_UP_DOWN_MENU (MarlinFirmware#25303)

    Co-authored-by: Dan Royer <1464454+i-make-robots@users.noreply.github.com>

commit 5446968
Author: thinkyhead <thinkyhead@users.noreply.github.com>
Date:   Tue Jan 31 06:05:55 2023 +0000

    [cron] Bump distribution date (2023-01-31)

commit 2dda0c0
Author: Giuliano Zaro <3684609+GMagician@users.noreply.github.com>
Date:   Tue Jan 31 06:07:51 2023 +0100

    🌐 Update Italian language (MarlinFirmware#25309)

commit 7ad3586
Author: Roman Moravčík <roman.moravcik@gmail.com>
Date:   Tue Jan 31 06:07:03 2023 +0100

    🌐 Update Slovak language (MarlinFirmware#25305)

commit 087e19a
Author: Scott Lahteine <thinkyhead@users.noreply.github.com>
Date:   Mon Jan 30 22:11:50 2023 -0600

    🔧 Fix build with no Y axis (MarlinFirmware#25311)

commit d0a965a
Author: Darren Garnier <dgarnier@reinrag.net>
Date:   Mon Jan 30 23:00:49 2023 -0500

    🔨 Fix config.ini URL fetch (MarlinFirmware#25313)

commit 0c181fc
Author: Bob Kuhn <bob.kuhn@att.net>
Date:   Mon Jan 30 21:57:36 2023 -0600

    🩹 Fix G61 axis parameters with no offset (MarlinFirmware#25312)

commit 67bc855
Author: thinkyhead <thinkyhead@users.noreply.github.com>
Date:   Fri Jan 27 00:27:06 2023 +0000

    [cron] Bump distribution date (2023-01-27)

commit ab767a4
Author: alexgrach <gav@bmstu.ru>
Date:   Fri Jan 27 03:20:09 2023 +0300

    🐛 Fix TFT Color UI LCD_HEIGHT (MarlinFirmware#25281)

commit 0e748da
Author: xBiohazardx <36756950+xBiohazardx@users.noreply.github.com>
Date:   Fri Jan 27 01:05:04 2023 +0100

    ✏️ Fix probe invert flag (MarlinFirmware#25282)

commit 2637153
Author: thinkyhead <thinkyhead@users.noreply.github.com>
Date:   Thu Jan 26 06:05:55 2023 +0000

    [cron] Bump distribution date (2023-01-26)

commit a2c93c2
Author: avionix-g <63542699+avionix-g@users.noreply.github.com>
Date:   Wed Jan 25 23:14:52 2023 -0500

    🐛 Fix MKS board Ultipanel support (MarlinFirmware#25278)

commit 4f902ac
Author: Alexander Gavrilenko <jmz52@users.noreply.github.com>
Date:   Thu Jan 26 07:05:43 2023 +0300

    🐛 Fix Simulator TFT compile (MarlinFirmware#25279)

commit cf02107
Author: Scott Lahteine <thinkyhead@users.noreply.github.com>
Date:   Wed Jan 25 21:37:10 2023 -0600

    🔧 Refine Input Shaping check (MarlinFirmware#25280)

commit 7a49fab
Author: thinkyhead <thinkyhead@users.noreply.github.com>
Date:   Tue Jan 24 12:07:25 2023 +0000

    [cron] Bump distribution date (2023-01-24)

commit 7393285
Author: Scott Lahteine <thinkyhead@users.noreply.github.com>
Date:   Fri Jan 20 21:17:13 2023 -0600

    SDIO retry, hsd clock, etc.

commit e0ae072
Author: Scott Lahteine <thinkyhead@users.noreply.github.com>
Date:   Tue Jan 24 02:21:02 2023 -0600

    🔧 Overridable Stepper EN init

commit 4099763
Author: thinkyhead <thinkyhead@users.noreply.github.com>
Date:   Mon Jan 23 12:07:26 2023 +0000

    [cron] Bump distribution date (2023-01-23)

commit 3268897
Author: Bob Kuhn <bob.kuhn@att.net>
Date:   Mon Jan 23 01:37:35 2023 -0600

    🐛 Fix Ender-2 Stock Display with Melzi (MarlinFirmware#25258)

commit fffc966
Author: Scott Lahteine <thinkyhead@users.noreply.github.com>
Date:   Mon Jan 23 01:22:03 2023 -0600

    🐛 Fix homing_needed_error bits

commit e656f10
Author: thinkyhead <thinkyhead@users.noreply.github.com>
Date:   Sun Jan 22 06:05:45 2023 +0000

    [cron] Bump distribution date (2023-01-22)

commit 7e72981
Author: Scott Lahteine <thinkyhead@users.noreply.github.com>
Date:   Sat Jan 21 22:57:56 2023 -0600

    🚸 Fix homing_needed_error language

commit b7c2363
Author: ellensp <530024+ellensp@users.noreply.github.com>
Date:   Sun Jan 22 15:08:37 2023 +1300

    🐛 Fix misc. UI issues (MarlinFirmware#25252)

    Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>

commit f2b8942
Author: thinkyhead <thinkyhead@users.noreply.github.com>
Date:   Wed Jan 18 00:22:56 2023 +0000

    [cron] Bump distribution date (2023-01-18)

commit f81c468
Author: John Robertson <john@cirtech.co.uk>
Date:   Tue Jan 17 23:53:39 2023 +0000

    🐛 Fix potential I2S buffer overwrite (MarlinFirmware#25113)

commit b3f65b6
Author: Miguel Risco-Castillo <mriscoc@users.noreply.github.com>
Date:   Tue Jan 17 18:41:36 2023 -0500

    🚸 ProUI MPC menu (MarlinFirmware#25232)

    Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>

commit 99d1b04
Author: alexgrach <gav@bmstu.ru>
Date:   Wed Jan 18 02:37:19 2023 +0300

    ✨ TFT 320x240 portrait (MarlinFirmware#25207)

    Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>

commit 58f64ea
Author: thinkyhead <thinkyhead@users.noreply.github.com>
Date:   Tue Jan 17 06:05:52 2023 +0000

    [cron] Bump distribution date (2023-01-17)

commit c448208
Author: Scott Lahteine <thinkyhead@users.noreply.github.com>
Date:   Mon Jan 16 22:11:49 2023 -0600

    🎨 Heading cleanup

commit 938d7b5
Author: thinkyhead <thinkyhead@users.noreply.github.com>
Date:   Mon Jan 16 00:22:07 2023 +0000

    [cron] Bump distribution date (2023-01-16)

commit 6fe387b
Author: Scott Lahteine <thinkyhead@users.noreply.github.com>
Date:   Sun Jan 15 06:48:17 2023 -0600

    🧑‍💻 Adjust PID / MPC / ProUI

    Changes to simplify MarlinFirmware#25232 WIP

commit d94defc
Author: Scott Lahteine <thinkyhead@users.noreply.github.com>
Date:   Sun Jan 15 06:48:17 2023 -0600

    🎨 Language / menu cleanup

commit 212167b
Author: Keith Bennett <13375512+thisiskeithb@users.noreply.github.com>
Date:   Sun Jan 15 05:25:36 2023 -0800

    📝 No longer experimental (MarlinFirmware#25238)

commit d753781
Author: thinkyhead <thinkyhead@users.noreply.github.com>
Date:   Sun Jan 15 12:06:24 2023 +0000

    [cron] Bump distribution date (2023-01-15)

commit da87c20
Author: Scott Lahteine <thinkyhead@users.noreply.github.com>
Date:   Sun Jan 15 01:19:45 2023 -0600

    🔖  Config version 02010300

commit 5acf738
Author: Scott Lahteine <thinkyhead@users.noreply.github.com>
Date:   Sun Jan 15 01:11:49 2023 -0600

    🔧 Added MOTHERBOARD error text

commit 80a2555
Author: thinkyhead <thinkyhead@users.noreply.github.com>
Date:   Sat Jan 14 18:05:38 2023 +0000

    [cron] Bump distribution date (2023-01-14)

commit 5fd5cb0
Author: Scott Lahteine <thinkyhead@users.noreply.github.com>
Date:   Sat Jan 14 07:44:57 2023 -0600

    ✏️  ProUI followup

commit 7503ac3
Author: thinkyhead <thinkyhead@users.noreply.github.com>
Date:   Fri Jan 13 00:22:51 2023 +0000

    [cron] Bump distribution date (2023-01-13)

commit 80dc7b2
Author: Scott Lahteine <thinkyhead@users.noreply.github.com>
Date:   Wed Jan 11 20:31:46 2023 -0600

    🔧 Input Shaping sanity checks

commit 3d0b11a
Author: thinkyhead <thinkyhead@users.noreply.github.com>
Date:   Thu Jan 12 01:39:45 2023 +0000

    [cron] Bump distribution date (2023-01-12)

commit 73fa199
Merge: 6444761 0838f70
Author: uBaHoFF <85784399+uBaHoFF@users.noreply.github.com>
Date:   Thu Jan 12 01:20:10 2023 +0200

    Merge branch 'bugfix-2.1.x' into HEVO-BTT-SKR-1.3

commit 0838f70
Author: Scott Lahteine <thinkyhead@users.noreply.github.com>
Date:   Wed Jan 11 01:19:54 2023 -0600

    🩹 Fix Sim with USE_WATCHDOG disabled

commit 5af5c2a
Author: Scott Lahteine <thinkyhead@users.noreply.github.com>
Date:   Wed Jan 11 01:19:45 2023 -0600

    🔨 Improve config.ini parser

commit fe62c80
Author: thinkyhead <thinkyhead@users.noreply.github.com>
Date:   Wed Jan 11 06:24:37 2023 +0000

    [cron] Bump distribution date (2023-01-11)

commit 64167df
Author: Powerlated <zjia08@gmail.com>
Date:   Wed Jan 11 00:40:15 2023 -0500

    ✨ PREHEAT_TIME_BED_MS (MarlinFirmware#25146)

commit 250fd60
Author: Alex Z <ad_user@runbox.com>
Date:   Wed Jan 11 15:22:28 2023 +1000

    🐛 Fix Chitu V6 Z_STOP_PIN (MarlinFirmware#25227)

commit 01e58de
Author: Scott Lahteine <thinkyhead@users.noreply.github.com>
Date:   Tue Jan 10 22:38:08 2023 -0600

    🩹 ProUI - Remove ManualZOffset

commit 7717beb
Author: kadir ilkimen <kadirilkimen@gmail.com>
Date:   Wed Jan 11 06:29:38 2023 +0200

    ✨ Polar Kinematics (MarlinFirmware#25214)

commit 33e5aad
Author: thinkyhead <thinkyhead@users.noreply.github.com>
Date:   Tue Jan 10 01:41:43 2023 +0000

    [cron] Bump distribution date (2023-01-10)
thinkyhead pushed a commit to thinkyhead/Marlin that referenced this pull request Feb 22, 2023
@thisiskeithb @thinkyhead
📝 No longer experimental (MarlinFirmware#25238)
9641e66
@thisiskeithb thisiskeithb mentioned this pull request Mar 16, 2023
Merged
thisiskeithb added a commit to thisiskeithb/Marlin that referenced this pull request Mar 17, 2023
@thisiskeithb
Square Wave Stepping & SPI Endstops No Longer Beta
38f30e4 
Followup to MarlinFirmware#25238
thinkyhead pushed a commit that referenced this pull request Apr 7, 2023
@thisiskeithb @thinkyhead
📝 No longer experimental (#25238)
ba84865
thinkyhead pushed a commit that referenced this pull request Apr 10, 2023
@thisiskeithb @thinkyhead
📝 No longer experimental (#25238)
6b48517
thinkyhead pushed a commit to thinkyhead/Marlin that referenced this pull request May 16, 2023
@thisiskeithb @thinkyhead
📝 No longer experimental (MarlinFirmware#25238)
a5a4bcd
@neclimdul neclimdul mentioned this pull request May 24, 2023
Open
tspiva pushed a commit to tspiva/Marlin that referenced this pull request May 25, 2023
@thisiskeithb
📝 No longer experimental (MarlinFirmware#25238)
b1b88ec
Andy-Big pushed a commit to Andy-Big/Marlin_FB_Reborn that referenced this pull request Jul 9, 2023
@thisiskeithb @Andy-Big
📝 No longer experimental (MarlinFirmware#25238)
6daec1a
@vovodroid vovodroid mentioned this pull request Jan 9, 2024
Open
2 tasks
@nerdyscout
Copy link

nerdyscout commented Oct 13, 2024 •
edited
Loading

I just experienced some issues building marlin with EXPERIMENTAL_I2CBUS for samd51.
When enabled I can build and upload, but no tty comes up. looks like some firmware is not booting, guess some memory leaking or so... behavior is exactly like 22456

@thisiskeithb
Copy link
Member Author

I just experienced some issues building marlin with EXPERIMENTAL_I2CBUS for samd51. When enabled I can build and upload, but no tty comes up. looks like some firmware is not booting, guess some memory leaking or so... behavior is exactly like #22456

As noted above:

The I2CBUS stuff is meant for developers to experiment, and doesn't do anything useful without added code.

So you’d need to add code for it to work. This isn’t the place to ask for help though.

This Issue Queue is for Marlin bug reports and development-related issues, and we prefer not to handle user-support questions here. (As noted on this page.) For best results getting help with configuration and troubleshooting, please use the following resources:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C: Configuration C: Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thisiskeithb @GMagician @thinkyhead @nerdyscout