Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anycubic Vyper and stock Vyper LCD #25405

Merged
merged 82 commits into from
Mar 26, 2023

Conversation

Bob-the-Kuhn
Copy link
Contributor

@Bob-the-Kuhn Bob-the-Kuhn commented Feb 19, 2023

This PR adds support for the motherboard and display used in the Anycubic Vyper printer.

A separate PR will be submitted for the Configuration.h and Configuration_adv.h files specific to this printer.

99% of the code changes are to support the display.

The new code and the pins_AC_TRI_F1_V1.h file are copied from the Anycubic Vyper 2.4.5 software and adapted for use with bugfix-2.1.x.

This code was developed in response to a post on the Facebook group Marlin Firmware for 3D. See that post on the testing that was done.


The Anycubic Vyper's display is a DGUS LCD. The user reported that none of the existing DGUS options gave satisfactory results so the Anycubic DGUS support was ported over.

I'm not sure where to group the Vyper's DGUS LCD in Configuration.h. It could either go with the other Anycubic LCDs or with the DGUS displays. The Anycubic DWIN_SET is available from Anycubic here.


EDIT

Turns out the motherboard is a Trigorilla V0.0.6 GD32F103 unit. Marlin doesn't support the GD32 series chip so the motherboard is being dropped from this PR.

EDIT 2

I've added the changes per @ellensp and renamed the board to TRIGORILLA_V006.

@ellensp
Copy link
Contributor

ellensp commented Feb 19, 2023

Except the board has a GD32 not a STM32....

@Bob-the-Kuhn
Copy link
Contributor Author

I just got feedback from the user.

You are mostly correct. It is a Trigorilla V0.0.6 motherboard with a GD32F103 chip on it.

Very disappointed.

Definitely no reason to add the motherboard.

Without the motherboard I suspect that there will be very few people interested in just the display support.

Do you think it's worthwhile to continue with just adding the display?

@ellensp
Copy link
Contributor

ellensp commented Feb 19, 2023

one day GD32 will be supported.
So I say continue, but add something like this to end of board pin.h for now

#ifndef I_UNDERSTAND_AND_ACCEPT_THAT_THERE_IS_ZERO_SUPPORT_FOR_THIS_CONTROLLER
  #error "WARNING: GD32 based controllers are NOT officially supported by Marlin (at this time)"
  #error "You will get ZERO support from the Marlin community for this controller"
  #error "add #define I_UNDERSTAND_AND_ACCEPT_THAT_THERE_IS_ZERO_SUPPORT_FOR_THIS_CONTROLLER to your configuration.h to continue at your own risk"
#endif

And add this define to the Config files, but disabled.

@thinkyhead
Copy link
Member

Do you think it's worthwhile to continue with just adding the display?

Sure, as apparently it's very similar to others in the lcd/extui/dgus folder. But, it should be unified with the gang of displays in that folder since it matches the same implementation pattern. If we can do the same for the extui/dgus_reloaded display that would be a bonus. The more redundancy we can eliminate, the easier it will be for vendors to implement similar displays without reinventing the wheel each time.

@thinkyhead
Copy link
Member

one day GD32 will be supported.

Facilitating the use of GD32 is not the same as distributing binaries that use it with STMicro USB in contravention of their USB license, so I have personally chilled out more about supporting GD32 and I think it would be okay to include it as one of the platform targets going forward, although it would be best if we also got formal support for that MCU variant within PlatformIO. AFAIK the Marlin forks that include GD32 are currently treating it as a variant of STM32.

…arnings

add the motherboard back in

changed the motherboard name to BOARD_TRIGORILLA_V006

added the folder gd32f1 under pins
put the new board into this folder
added a env_validate.h that has a warning/error about an unsupported CPU

fixed type in anycubic_extui.cpp

fixed compiler warnings
dgus_tft.cpp
DGUSScreenHandler.cpp
@@ -98,7 +98,7 @@ namespace Anycubic {
bool DgusTFT::data_received;
uint8_t DgusTFT::data_buf[DATA_BUF_SIZE];
uint8_t DgusTFT::data_index;
uint32_t DgusTFT::page_index_now, DgusTFT::page_index_last, DgusTFT::page_index_last_2;
uint16_t DgusTFT::page_index_now, DgusTFT::page_index_last, DgusTFT::page_index_last_2;
Copy link
Member

@thinkyhead thinkyhead Mar 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bob-the-Kuhn — This commit formalizes the fact that the values being provided are being sent with two byte transfers. … Assuming that the endian changes from the previous commit are ok. I would expect the changes related to endianness are the most likely culprit for any new problems.

*v_u8 = (uint8_t *)(&value);
uint8_t data[] = { 0x5A, 0xA5, 0x05, 0x82, a_u8[1], a_u8[0], v_u8[1], v_u8[0] };
void DgusTFT::SendValueToTFT(const uint16_t value, const uint32_t address) {
uint8_t data[] = { 0x5A, 0xA5, 0x05, 0x82, uint8_t(address >> 8), uint8_t(address & 0xFF), uint8_t(value >> 8), uint8_t(value & 0xFF) };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bob-the-Kuhn — Compare the old behavior to the new behavior with some serial logging. There is a clear assumption here that only the low 16 bits of the value and the address are relevant, and since the old code was looking at the first two bytes the assumption is that the MCU is little-endian. Thus a_u8[1] must be the high order address byte and a_u8[0] is the low order byte. The same must be true for the value. But serial logging should more firmly establish that the result is the same or not.

So, I will start by scanning this commit for any obvious typos.


if ((control_index & 0xF000) == KEY_ADDRESS) {// is KEY
control_index = uint16_t(data_buf[1] << 8) | uint16_t(data_buf[2]);
if (control_index == KEY_ADDRESS) { // is KEY
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bob-the-Kuhn — This is clearly my error. It should be (control_index & 0xF000) == KEY_ADDRESS. Hopefully, my only error!

if ((control_value & 0x00FFFFFF) == 0x010072) { // startup last gif

control_value = (uint32_t(data_buf[3]) << 16) | (uint32_t(data_buf[4]) << 8) | uint32_t(data_buf[5]);
if (control_value == 0x010072) { // startup last gif
Copy link
Member

@thinkyhead thinkyhead Mar 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bob-the-Kuhn — The control_value & 0x00FFFFFF is not needed here (or below), however, since control_value is initialized to 0 before this, and it is not otherwise modified.

thinkyhead added a commit that referenced this pull request Mar 27, 2023
thinkyhead added a commit that referenced this pull request Mar 27, 2023
@thinkyhead
Copy link
Member

I found one obvious mistake, patched with 0867561. Let me know if there are still issues, and I will continue to scan the changes for any other oopsies.

@BassXX
Copy link

BassXX commented Apr 4, 2023

@Bob-the-Kuhn

Hi there, not sure if I understand that correctly, but does that mean Marlin is now compatible with the Anycubic Vyper?

Or not yet?
Thanks and Regards

@Bob-the-Kuhn
Copy link
Contributor Author

Yes & no.

Yes, Marlin now officially supports Vyper.

No, there are known issues with the currect code.

As far as I know the discussions about the open issues are only on this Facebook thread.

Roi Rguez Huertas has a fork with a couple of the issues fixed. It can be accessed here.

@BassXX
Copy link

BassXX commented Apr 4, 2023

Hmm I dont use facebook. What kind of/how severe are those issues?

Is it too early to build & flash it yet, in order to use the printer normally?

Thanks and regards

@Bob-the-Kuhn
Copy link
Contributor Author

At one time power loss recovery wasn't being automatically enabled. An attempt was made to fix it but I have not heard back on it's status.

The feedrate % field on the status screen isn't populated the first time.

@BassXX
Copy link

BassXX commented Apr 5, 2023

Ok but these are minor issues as it seems and they will be fixed in future I assume.
However, good news that I can bring MarlinFirmware on the Anycubic Vyper now!

shadow578 added a commit to shadow578/Marlin-H32 that referenced this pull request Apr 7, 2023
* [cron] Bump distribution date (2023-03-05)

* 🐛 Fix apply_power for SPINDLE_SERVO (MarlinFirmware#25465)

* 🐛 Fix Flash EEPROM for STM32G0B1CB (MarlinFirmware#25469)

* 🌐 Update Turkish language (MarlinFirmware#25447)

* [cron] Bump distribution date (2023-03-06)

* 🧑‍💻 Script to make non-accented languages

* 🌐 Update Turkish language

Followup to MarlinFirmware#25447

* [cron] Bump distribution date (2023-03-07)

* 🌐 DGUS Reloaded non-accented French (MarlinFirmware#25443)

Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>

* 🔧 Add DGUS_LCD_UI RELOADED conditions

* [cron] Bump distribution date (2023-03-08)

* ✨ Extra Z Servo Probe options (MarlinFirmware#21427)

Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>

* 🔧 Update some config.ini options

* 🔨 VSCode + Devcontainer support (MarlinFirmware#22420)

* [cron] Bump distribution date (2023-03-09)

* ✨ Z_SAFE_HOMING_POINT_ABSOLUTE (MarlinFirmware#23069)

* [cron] Bump distribution date (2023-03-10)

* ✨ BTT Octopus Max EZ 1.0, SKR 3.0 / 3.0 EZ (MarlinFirmware#25387)

BTT Octopus Max EZ V1.0 (STM32H723VE/ZE), SKR V3.0 / V3.0 EZ (STM32H723VG)

* [cron] Bump distribution date (2023-03-11)

* 🐛 Fix Anet ET4 SD_SS_PIN (MarlinFirmware#25492)

* [cron] Bump distribution date (2023-03-12)

* BTT Octopus … followup (MarlinFirmware#25495)

Followup to MarlinFirmware#25387

* ⚡️ Exit from ISR on AVR already does sei

Co-Authored-By: tombrazier <68918209+tombrazier@users.noreply.github.com>

* 🎨 Cosmetic stepper updates

Co-Authored-By: tombrazier <68918209+tombrazier@users.noreply.github.com>

* ✨ MAX7219_DEBUG_MULTISTEPPING

Co-Authored-By: tombrazier <68918209+tombrazier@users.noreply.github.com>

* ⚡️ Use hal_timer_t for timing vars

Co-Authored-By: tombrazier <68918209+tombrazier@users.noreply.github.com>

* ⚡️ Use cached la_active state

Co-Authored-By: tombrazier <68918209+tombrazier@users.noreply.github.com>

* ⚡️ Use AxisFlags for step_needed

Co-Authored-By: tombrazier <68918209+tombrazier@users.noreply.github.com>

* [cron] Bump distribution date (2023-03-13)

* ⚡️ Major shaper optimization

Co-Authored-By: tombrazier <68918209+tombrazier@users.noreply.github.com>

* ⚡️ Set steps_per_isr in calc_multistep_timer_interval

Co-Authored-By: tombrazier <68918209+tombrazier@users.noreply.github.com>

* 🔧 Expose MULTISTEPPING_LIMIT option

Co-Authored-By: tombrazier <68918209+tombrazier@users.noreply.github.com>

* ⚡️ Optimize speed lookup for AVR

Co-Authored-By: tombrazier <68918209+tombrazier@users.noreply.github.com>

* ⚡️ Update ISR cycle counts

Co-Authored-By: tombrazier <68918209+tombrazier@users.noreply.github.com>

* 📺 DGUS_RELOADED 1.03 (MarlinFirmware#25490)

* [cron] Bump distribution date (2023-03-14)

* 🐛 Fix Polargraph without Z (MarlinFirmware#25514)

* 🐛 Fix long filename read/report (MarlinFirmware#25509)

* 🩹 Fix IA_CREALITY float, startup (MarlinFirmware#25493)

Followup to MarlinFirmware#25440

* [cron] Bump distribution date (2023-03-15)

* 🎨 Misc. formatting

* 🎨 Misc. tramming menu cleanup (MarlinFirmware#25519)

* 🩹 Fan Menu / Status fixes

Followup to MarlinFirmware#21888

* 🩹 Fix DWIN MarlinUI Fan/E/XY (MarlinFirmware#25502)

* [cron] Bump distribution date (2023-03-16)

* 🔧 Safer default for Z_MIN_PROBE_PIN override (MarlinFirmware#25524)

Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>

* ♻️ Refactor PROBE_PT_[123]

* ♻️ Refactor UBL 'G29 J'

* [cron] Bump distribution date (2023-03-17)

* 🚸 Refinements for UBL G29 J (tilt mesh) (MarlinFirmware#25486)

* [cron] Bump distribution date (2023-03-18)

* 🔧 Optional MPC_AUTOTUNE to save 5.5 - 5.8KB

* ✨ Sovol v1.3.1 (Sovol SV06) (MarlinFirmware#25267)

* 🧑‍💻 More IntelliSense-friendly declares

* 🎨 Clean up IA_CREALITY includes (MarlinFirmware#25530)

* 🎨 Suppress warning (MarlinFirmware#25529)

* 🔧 SQUARE_WAVE_STEPPING => EDGE_STEPPING (MarlinFirmware#25526)

Co-Authored-By: Scott Lahteine <thinkyhead@users.noreply.github.com>

* 🚸 Improve Z-Probe raise for deploy (MarlinFirmware#25498)

Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>

* 🐛 Fix LVGL / MKS WiFi long filename (MarlinFirmware#25483)

Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>

* 🔨 Fix STM32H723Vx_btt for case-sensitive (MarlinFirmware#25535)

* 🐛 Fix FYSETC Cheetah v2.0 Servo/Probe pins (MarlinFirmware#24635)

Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>

* 🐛 Prevent MPC E-permm overrun in Load Filament (MarlinFirmware#25531)

Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>

* 🚸 Fix / improve LCD_BED_TRAMMING (MarlinFirmware#25425)

Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>

* 🔧 Sanity-check PRINTCOUNTER_SAVE_INTERVAL + ESP32 I2S Exp (MarlinFirmware#25527)

Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>

* ⚡️ Smart Adaptive Multi-Stepping (MarlinFirmware#25474)

* 🚸 Temperature Variance Monitor tweaks (MarlinFirmware#23571)

Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>

* 🩹 Fix Ender 2 stock LCD (MarlinFirmware#25538)

* ⚡️ Misc. optimizations

* [cron] Bump distribution date (2023-03-19)

* ✨ REPORT_ADAPTIVE_FAN_SLOWING (MarlinFirmware#25537)

* 🩹 Fix a serial_ternary

* ✨ Z_SERVO_DEACTIVATE_AFTER_STOW (MarlinFirmware#24215)

* 🐛 Avoid step rate overflow (MarlinFirmware#25541)

* [cron] Bump distribution date (2023-03-20)

* ✨ PROBING_TOOL (MarlinFirmware#24411)

* [cron] Bump distribution date (2023-03-22)

* ✨ FILAMENT_SWITCH_AND_MOTION (MarlinFirmware#25548)

Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>

* 🧑‍💻 ExtUI::onSetPowerLoss

* [cron] Bump distribution date (2023-03-23)

* 🎨 calibration_stage => stage

* [cron] Bump distribution date (2023-03-24)

* 🩹 Reset touch screen calibration on failure (MarlinFirmware#25334)

Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>

* 🎨 TMC SPI Pins

Co-Authored-By: Martin Turski <turningtides@outlook.de>

* 🎨 Pins header comments

Co-Authored-By: Martin Turski <turningtides@outlook.de>

* 🎨 Wrap font includes

Co-Authored-By: Martin Turski <turningtides@outlook.de>

* 🎨 LPC_SOFTWARE_SPI => SOFTWARE_SPI

Co-Authored-By: Martin Turski <turningtides@outlook.de>

* 🔨 INI Updates

Co-Authored-By: Martin Turski <turningtides@outlook.de>

* 🎨 Misc. fixes, cleanup

Co-Authored-By: Martin Turski <turningtides@outlook.de>

* 🩹 Update TRONXY_V10 SPI_FLASH pins

* [cron] Bump distribution date (2023-03-25)

* 🩹 Fix Chitu3D V6 default probe pin (MarlinFirmware#25552)

* 🔧 Remove TVPM warning (MarlinFirmware#25551)

* 🐛 Fix MKS Gen L 2.1 MOSFET pins (MarlinFirmware#25542)

* 🩹 Refine MKS boards with a dedicated FAN port (MarlinFirmware#25567)

* 🎨 Rename FAN_PIN to FAN0_PIN (MarlinFirmware#25568)

* 📝 Fix spelling (MarlinFirmware#25563)

* [cron] Bump distribution date (2023-03-26)

* 🎨 Timer tweaks

* 🔧 Refactor endstop state config (MarlinFirmware#25574)

* ✨ AnyCubic Vyper / Vyper LCD (MarlinFirmware#25405)

* 🩹 Fix Touch Calibration first point (MarlinFirmware#25298)

* 🧑‍💻 Auto Fan / Cooler Fan updates (MarlinFirmware#25554)

* 🐛 Prevent divide-by-zero in calc_timer_interval (MarlinFirmware#25557)

* 🔧 Sanity-check for endstop inverting

Followup to MarlinFirmware#25574

* 🔧 Clarify axis disable / timeout (MarlinFirmware#25571)

* [cron] Bump distribution date (2023-03-27)

* 🔨 Fix thread-unsafe deque iteration

* 🐛 Fix AnyCubic Vyper ProcessPanelRequest

Followup to MarlinFirmware#25405

* 🎨 Suppress a type warning (MarlinFirmware#25575)

* ⚡️ Improve TFT DMA for STM32 (MarlinFirmware#25359)

* 🐛 Fix M23 long filename support (MarlinFirmware#25540)

* [cron] Bump distribution date (2023-03-28)

* 🎨 Misc. cleanup

* 🔧 Fix up WiFi options (MarlinFirmware#25586)

* 🔨 Update config.ini endstop states

Followup to MarlinFirmware#25574

* [cron] Bump distribution date (2023-03-29)

* 🔧 Impose Hephestos 2 Bed Kit requirements (MarlinFirmware#25585)

* 🎨 Remove unused ProUI : UBLValidMesh (MarlinFirmware#25591)

* 🔨 Improve Docker local tests support (MarlinFirmware#25583)

* 🔨 MarlinSimUI updates (MarlinFirmware#25589)

* [cron] Bump distribution date (2023-03-30)

* 🩹 Update Trigorilla V006 fan pin

Followup to MarlinFirmware#25568

* 🩹 Fix Ender-3 V2 with no fan

* 🐛 Fix _HAS_FAN for fan on Pin 0

* 🎨 Refine probe, more debug

* 🩹 Fix displayed mix percentages

* [cron] Bump distribution date (2023-03-31)

* 🔧  DGUS_LCD_UI selectable options

* 🔧 Fix SENSORLESS hit state error (MarlinFirmware#25604)

* 🧑‍💻 CardReader adjustments (MarlinFirmware#25611)

* [cron] Bump distribution date (2023-04-01)

* 🎨  HAS_SHAPING => HAS_ZV_SHAPING

* ✨ Fixed-Time Motion with Input Shaping by Ulendo (MarlinFirmware#25394)

Co-authored-by: Ulendo Alex <alex@ulendo.io>

* 🐛 Fix Long FIlename lookup (MarlinFirmware#25598)

* 🌐 Update Italian language (MarlinFirmware#25587)

* 🔨 Move Docker local test script

Followup to MarlinFirmware#25583

* 🩹 FT_MOTION Followup

* 🐛 Ensure root for 'M503 C'

* 🐛 Clean up DELTA babystep Z

* 🐛 INVERT_*_DIR for FT_MOTION (MarlinFirmware#25637)

* 🔧 Move DOGLCD options

* 🧑‍💻 Update pinsformat.js

* 📝 Update Ender # labels

* [cron] Bump distribution date (2023-04-07)

* 🚸 Support CoreXY without Z (MarlinFirmware#25630)

* 🎨 Apply const (MarlinFirmware#25643)

* update `pins_Aquila_X2.h` to new format

---------

Co-authored-by: thinkyhead <thinkyhead@users.noreply.github.com>
Co-authored-by: Hans-Christian Ebke <ebke@cs.rwth-aachen.de>
Co-authored-by: alextrical <35117191+alextrical@users.noreply.github.com>
Co-authored-by: Abdullah YILMAZ <h.abdullahyilmaz@hotmail.com>
Co-authored-by: albatorsssx <albator_ssx@hotmail.com>
Co-authored-by: Kurt Haenen <Misterke@users.noreply.github.com>
Co-authored-by: Sion Williams <sion5@hotmail.co.uk>
Co-authored-by: Evgeniy Zhabotinskiy <evg-zhabotinsky@users.noreply.github.com>
Co-authored-by: Keith Bennett <13375512+thisiskeithb@users.noreply.github.com>
Co-authored-by: tombrazier <68918209+tombrazier@users.noreply.github.com>
Co-authored-by: Neo2003 <Neo2003@users.noreply.github.com>
Co-authored-by: jbubik <jbubik@centrum.cz>
Co-authored-by: Eduard Sukharev <sukharev.eh@gmail.com>
Co-authored-by: Davide Rombolà <davide.rombola@gmail.com>
Co-authored-by: dwzg <50058606+dwzg@users.noreply.github.com>
Co-authored-by: ellensp <530024+ellensp@users.noreply.github.com>
Co-authored-by: jamespearson04 <jamespearson04@hotmail.co.uk>
Co-authored-by: Michael Hill <mhill@hillsoftware.com>
Co-authored-by: James Gilliland <neclimdul@gmail.com>
Co-authored-by: Liam Powell <liam+github@liampwll.com>
Co-authored-by: George Fu <nailao_5918@163.com>
Co-authored-by: Piotr Paczyński <ppaczyn@gmail.com>
Co-authored-by: Farva42 <100859196+Farva42@users.noreply.github.com>
Co-authored-by: John Robertson <john@cirtech.co.uk>
Co-authored-by: John Lagonikas <39417467+zeleps@users.noreply.github.com>
Co-authored-by: StevilKnevil <stevilknevil@hotmail.co.uk>
Co-authored-by: FilippoR <filippo.rossoni@gmail.com>
Co-authored-by: BIGTREETECH <38851044+bigtreetech@users.noreply.github.com>
Co-authored-by: Martin Turski <turningtides@outlook.de>
Co-authored-by: Giuliano Zaro <3684609+GMagician@users.noreply.github.com>
Co-authored-by: Bob Kuhn <bob.kuhn@att.net>
Co-authored-by: Alexander Gavrilenko <jmz52@users.noreply.github.com>
Co-authored-by: Andrew <18502096+classicrocker883@users.noreply.github.com>
Co-authored-by: John Unland <junland.foss@gmail.com>
Co-authored-by: Chris Pepper <p3p@p3psoft.co.uk>
Co-authored-by: Ulendo Alex <alex@ulendo.io>
EvilGremlin pushed a commit to EvilGremlin/Marlin that referenced this pull request Apr 8, 2023
EvilGremlin pushed a commit to EvilGremlin/Marlin that referenced this pull request Apr 8, 2023
thinkyhead pushed a commit that referenced this pull request Apr 10, 2023
thinkyhead added a commit that referenced this pull request Apr 10, 2023
@Mangers95
Copy link

I am still unable to build this firmware

*** [.pio\build\trigorilla_v006\src\src\lcd\extui\anycubic_vyper\FileNavigator.cpp.o] Error 1
Marlin\src\lcd\extui\anycubic_vyper\dgus_tft.cpp: In static member function 'static void Anycubic::DgusTFT::FilamentRunout()':
Marlin\src\lcd\extui\anycubic_vyper\dgus_tft.cpp:466:18: error: invalid conversion from 'const uint16_t*' {aka 'const short unsigned int*'} to 'uint8_t' {aka 'unsigned char'} [-fpermissive]
466 | PlayTune(FilamentOut, 1);
| ^~~~~~~~~~~
| |
| const uint16_t* {aka const short unsigned int*}
Marlin\src\lcd\extui\anycubic_vyper\dgus_tft.cpp:466:31: error: invalid conversion from 'int' to 'const uint16_t*' {aka 'const short unsigned int*'} [-fpermissive]
466 | PlayTune(FilamentOut, 1);
| ^
| |
| int
Marlin\src\lcd\extui\anycubic_vyper\dgus_tft.cpp:466:32: error: too few arguments to function 'void Anycubic::PlayTune(uint8_t, const uint16_t*, uint8_t)'
466 | PlayTune(FilamentOut, 1);
| ^
In file included from Marlin\src\lcd\extui\anycubic_vyper\dgus_tft.cpp:32:
Marlin\src\lcd\extui\anycubic_vyper../anycubic/Tunes.h:64:8: note: declared here
64 | void PlayTune(const uint8_t beeperPin, const uint16_t tune, const uint8_t speed);
| ^~~~~~~~
Marlin\src\lcd\extui\anycubic_vyper\dgus_tft.cpp: In static member function 'static void Anycubic::DgusTFT::ConfirmationRequest(const char
)':
Marlin\src\lcd\extui\anycubic_vyper\dgus_tft.cpp:508:20: error: invalid conversion from 'const uint16_t*' {aka 'const short unsigned int*'} to 'uint8_t' {aka 'unsigned char'} [-fpermissive]
508 | PlayTune(Heater_Timedout, 1);
| ^~~~~~~~~~~~~~~
| |
| const uint16_t* {aka const short unsigned int*}
Marlin\src\lcd\extui\anycubic_vyper\dgus_tft.cpp:508:37: error: invalid conversion from 'int' to 'const uint16_t*' {aka 'const short unsigned int*'} [-fpermissive]
508 | PlayTune(Heater_Timedout, 1);
| ^
| |
| int
compilation terminated due to -fmax-errors=5.
*** [.pio\build\trigorilla_v006\src\src\lcd\extui\anycubic_vyper\dgus_tft.cpp.o] Error 1

@Bob-the-Kuhn
Copy link
Contributor Author

Have you tried the latest bugfix-2.1.x? There's been changes to the Vyper code since this PR.

@Mangers95
Copy link

Yes, i have tried yesterday and downloaded the latest version .

But my auto build marlin shows the same issue in dgus_tft.cpp just like platform.io

@schroedingersZombie
Copy link

I'd suggest adding #define PROBE_TARE_PIN PB13in the pins definition. I had problems with ABL - enabling PROBE_TARE with the mentioned Pin seems to fix these problems for me.
The same Pin is already defined as "AUTO_LEVEL_TX_PIN" but that seems to be an Anycubic oddity.

thinkyhead pushed a commit to thinkyhead/Marlin that referenced this pull request May 16, 2023
thinkyhead added a commit to thinkyhead/Marlin that referenced this pull request May 16, 2023
EvilGremlin pushed a commit to EvilGremlin/Marlin that referenced this pull request May 17, 2023
EvilGremlin pushed a commit to EvilGremlin/Marlin that referenced this pull request May 17, 2023
tspiva pushed a commit to tspiva/Marlin that referenced this pull request May 25, 2023
tspiva pushed a commit to tspiva/Marlin that referenced this pull request May 25, 2023
Andy-Big pushed a commit to Andy-Big/Marlin_FB_Reborn that referenced this pull request Jul 11, 2023
Andy-Big pushed a commit to Andy-Big/Marlin_FB_Reborn that referenced this pull request Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants