-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi Part Cooling Fans With M106 & M107 #25808
Conversation
pwm fans for part cooling and add defines to switch on/off
we already have 1 additional fan
|
the comment for this define was so vague i had no idea that is was it was for, will see if i can expand this feature instead. |
I agree the name is not good... it is not what i called it in when i added it ... (DUAL_PART_COOLING_FANS) back n #21888 |
i started re-coding using the noted feature and seem to have found the feature to be kinda broken due to the way fan numbering handled. you should be able to have dual part cooler with fan0 and fan1 headers but it was written so that fan2 is required for dual. i had to comment out part of the sanity check due to the invalid numbering and adjust a few bits to correct the numbering. once i look over the changes again ill update this PR. additional testing will be needed for sure. |
If this PR is just meant to augment Alternatively, we could add a bit more control over #define PRINT_COOLING_FANS { { 0, 2 }, { 3, 5 } } …that specifies which fan indexes (as defined by pins files) are controlled and synchronized together via #ifndef PRINT_COOLING_FANS
#define PRINT_COOLING_FANS { { 0 }, { 1 } ... }
#endif The option would be error-checked to make sure there are no collisions with fan indexes that have been assigned for other purposes. |
fbc2cd2
to
7376090
Compare
I fixed up some things:
|
Currently, the |
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
Expand M106 & M107 with the ability to use up to 3 pwm fans for part cooling and add defines to switch on/off.
I have encountered a need for this feature a number of times and feel its time it become available to everyone.