-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ExtUI Additions #26754
ExtUI Additions #26754
Conversation
That's just not an ExtUI thing. Each LCD has to implement custom menus its own way using the data supplied in the configuration.
Leveling isn't completely done until all the attempts by |
See above on code comment, there are known implementations doing this is the wild.
Some UI's would hang on abort without this getting called. They go to a holding screen to indicate in process (Creality OEM E5Plus / CR10SPro) or disable processing of inputs until anything blocking returns done. Its done, success or not is another question. A flag for success would be fine, but it does need to hand off to the UI that the blocking action is finished. |
AFAIK the changes applied will keep things working and get out of the |
Adds Input Shaping control to Extensible UI
Adds missing leveling done call
Fixes typo on function name
Misc conditional and sanity check changes for ExtUI UIs
Generic ExtUI functions should have access to any potential subsets, such as the custom user menus and buffer free, as there is no definitive indication whats implemented.