Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚸 Fix UI behavior for G29 with retry #27146

Merged

Conversation

thinkyhead
Copy link
Member

From working on #26754 it looks like G29 with retry is not handled in the right order for EXTENSIBLE_UI and/or DWIN_CREALITY_LCD. This PR attempts to sort out the correct order of operations to show the user what's going on when G29 fails and retries. This is only a first attempt, so please report any issues that you experience with this rework.

thinkyhead added a commit to InsanityAutomation/Marlin that referenced this pull request Jun 2, 2024
@thinkyhead thinkyhead merged commit 5334a8f into MarlinFirmware:bugfix-2.1.x Jul 15, 2024
62 checks passed
@thinkyhead thinkyhead deleted the bf2_rework_G29_retry_PR branch July 15, 2024 18:59
@rondlh
Copy link
Contributor

rondlh commented Jul 17, 2024

As gcode.cpp now uses the extensible UI, I think it should also be included:

#if ENABLED(EXTENSIBLE_UI)
  #include "../lcd/extui/ui_api.h"
#endif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants