Fixed compilation for gcc-4.6.2 with avr-libc-1.8.0 #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type prog_char has been removed from avr-libc. The PROGMEM attribute is illigal on types. See http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38342 and the changelogs of avr-libc-1.8.0 Two consts modifiers where missing, which the new avr-gcc warns you about. <avr/delay.h> has been depricated a long time ago. <util/delay.h> should be used. I think the shipping avr with the windows arduino software has removed the warning. Removed a strange #define SERIAL from SdBaseFile, it was not used in the code anywhere, and caused a conflict with the default header from Arduino-1.0.
… (pronterface) could not see target extruder heater temperature to continue print
Added late z enable. (blddk request) Only calculate look ahead if >2 moves in buffer. Removed some FORCE_INLINE to save memory. Signed-off-by: Erik van der Zalm <erik@vdzalm.eu>
Needs some work to remove the blocking in read max6675.
Default off.
|
Added |
arades79
pushed a commit
to CELLINKAB/Marlin
that referenced
this pull request
Mar 15, 2024
remove DEBUG_ADD_STEPS and fix unit-step conversion for IRQ pulsed steps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've compiled the latest gcc for AVR, combined with the latest avr-libc. When I use this a few minor things pop up.
The prog_char has been removed. The reason is that it was never properly supported: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38342
Two const modifiers where missing in the speed lookup tables. This is needed for proper placement in flash.
The calculation of stepper_inactive_time overflows, because it's calculated with 16 bit values.
The PSTR macro works properly in this version.
<avr/delay.h> should be replaced with <util/delay.h>, the Arduino environment normally suppresses this warning. But the Arduino environment does support <util/delay.h>
After this the only warning left is about no heater configured for the bed. Which is fine.