fix: Correct SQL query pagination for DatasetVersion findAll method #2945

inanalper · 2024-10-23T22:53:37Z

Problem

#2944

Closes: #2944

Solution

Moved the misplaced LIMIT and OFFSET statements.

Checklist

[✅] You've signed-off your work
Your changes are accompanied by tests (if relevant)
[✅ ] Your change contains a small diff and is self-contained
You've updated any relevant documentation (if relevant)
You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
You've included a header in any source code files (if relevant)

boring-cyborg · 2024-10-23T22:53:42Z

Thanks for opening your first pull request in the Marquez project! Please check out our contributing guidelines (https://github.com/MarquezProject/marquez/blob/main/CONTRIBUTING.md).

netlify · 2024-10-23T22:53:52Z

✅ Deploy Preview for peppy-sprite-186812 canceled.

Name	Link
🔨 Latest commit	`e112c55`
🔍 Latest deploy log	https://app.netlify.com/sites/peppy-sprite-186812/deploys/671980fdf823fb0008ee78a2

Signed-off-by: Alper İnan <kurumsal.alper@gmail.com> Signed-off-by: Alper <kurumsal.alper@gmail.com>

codecov · 2024-10-23T23:14:24Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.16%. Comparing base (2ffe5aa) to head (e112c55).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##               main    #2945   +/-   ##
=========================================
  Coverage     81.16%   81.16%           
  Complexity     1506     1506           
=========================================
  Files           268      268           
  Lines          7363     7363           
  Branches        329      329           
=========================================
  Hits           5976     5976           
  Misses         1226     1226           
  Partials        161      161

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

wslulciuc

LGTM 👍

boring-cyborg · 2024-10-23T23:21:46Z

Great job! Congrats on your first merged pull request in the Marquez project!

* Fixing data quality display. (MarquezProject#2937) Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com> * Dataset Version call simplification (MarquezProject#2938) * Fixing data quality display. Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com> * Fixing dataset version calls. Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com> --------- Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com> * feat: allow db-migrate without version (MarquezProject#2936) Signed-off-by: David Goss <david@davidgoss.co> * Display full `runID` and check icon when copied (MarquezProject#2940) Signed-off-by: Willy Lulciuc <willy.lulciuc@gmail.com> * Deferred copy revert. (MarquezProject#2941) Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com> * Long text handling (MarquezProject#2942) * Deferred copy revert. Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com> * Long text handling. Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com> * Adding search back in. Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com> --------- Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com> * Use project root for docker volume prefix (MarquezProject#2943) Signed-off-by: Willy Lulciuc <willy.lulciuc@gmail.com> * fix: Correct SQL query pagination for DatasetVersion findAll method (MarquezProject#2945) Signed-off-by: Alper İnan <kurumsal.alper@gmail.com> Signed-off-by: Alper <kurumsal.alper@gmail.com> * Update changelog for `0.50.0` Signed-off-by: Willy Lulciuc <willy.lulciuc@gmail.com> * Replace `redoc-cli` with `redocly` Signed-off-by: Willy Lulciuc <willy.lulciuc@gmail.com> * Prepare for release 0.50.0 Signed-off-by: Willy Lulciuc <willy.lulciuc@gmail.com> * Prepare next development version 0.51.0-SNAPSHOT Signed-off-by: Willy Lulciuc <willy.lulciuc@gmail.com> * Templatize event time in `metadata.json` (MarquezProject#2946) * Templatize event time in `metadata.json` Signed-off-by: Willy Lulciuc <willy.lulciuc@gmail.com> * Use `metadata.template.json` Signed-off-by: Willy Lulciuc <willy.lulciuc@gmail.com> --------- Signed-off-by: Willy Lulciuc <willy.lulciuc@gmail.com> * Update CHANGELOG.md * Update `web/docs/demo.gif` (MarquezProject#2948) Signed-off-by: Willy Lulciuc <willy.lulciuc@gmail.com> * fix(deps): update dependency io.openlineage:openlineage-java to v1.23.0 (MarquezProject#2907) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency org.assertj:assertj-core to v3.26.3 (MarquezProject#2909) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Willy Lulciuc <willy@datakin.com> * fix(deps): update dependency org.postgresql:postgresql to v42.7.4 (MarquezProject#2912) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency org.opensearch.client:opensearch-rest-client to v2.17.1 (MarquezProject#2911) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Willy Lulciuc <willy@datakin.com> * fix(deps): update dependency org.apache.commons:commons-lang3 to v3.17.0 (MarquezProject#2908) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Ignore `**/stats/**` (MarquezProject#2952) Signed-off-by: Willy Lulciuc <willy.lulciuc@gmail.com> * Update compatibility for `0.50.0` * fix(deps): update dependency org.opensearch.client:opensearch-java to v2.16.0 (MarquezProject#2910) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * `Dataset.currentVersionUuid` `->` `DatasetVersion.uuid` (MarquezProject#2954) Signed-off-by: Willy Lulciuc <willy.lulciuc@gmail.com> * Update Events Page (MarquezProject#2955) * Tuning the events page for longer events. Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com> * Adding events file. Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com> * Refetch jobs button. Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com> * Refetch jobs button. Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com> * Lint Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com> --------- Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com> Co-authored-by: Willy Lulciuc <willy@datakin.com> * Lineage run attachment issue. (MarquezProject#2953) Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com> Co-authored-by: Willy Lulciuc <willy@datakin.com> * feature: Better handling of missing environment variables in setupProxy.js file. (MarquezProject#2956) Signed-off-by: Artur Owczarek <owczarek.artur@gmail.com> --------- Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com> Signed-off-by: David Goss <david@davidgoss.co> Signed-off-by: Willy Lulciuc <willy.lulciuc@gmail.com> Signed-off-by: Alper İnan <kurumsal.alper@gmail.com> Signed-off-by: Alper <kurumsal.alper@gmail.com> Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Artur Owczarek <owczarek.artur@gmail.com> Co-authored-by: Peter Hicks <phixMe@users.noreply.github.com> Co-authored-by: davidjgoss <david@davidgoss.co> Co-authored-by: Willy Lulciuc <willy@datakin.com> Co-authored-by: Alper İnan <65857758+inanalper@users.noreply.github.com> Co-authored-by: Willy Lulciuc <willy.lulciuc@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Artur Owczarek <owczarek.artur@gmail.com>

boring-cyborg bot added the api API layer changes label Oct 23, 2024

fix: Correct SQL query pagination for DatasetVersion findAll method

0e27258

Signed-off-by: Alper İnan <kurumsal.alper@gmail.com> Signed-off-by: Alper <kurumsal.alper@gmail.com>

inanalper force-pushed the bug/versions-sql-bug branch from 46b202f to 0e27258 Compare October 23, 2024 23:01

Merge branch 'main' into bug/versions-sql-bug

e112c55

wslulciuc approved these changes Oct 23, 2024

View reviewed changes

wslulciuc added this to the 0.50.0 milestone Oct 23, 2024

wslulciuc merged commit d6cf5af into MarquezProject:main Oct 23, 2024
16 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Correct SQL query pagination for DatasetVersion findAll method #2945

fix: Correct SQL query pagination for DatasetVersion findAll method #2945

inanalper commented Oct 23, 2024

boring-cyborg bot commented Oct 23, 2024

netlify bot commented Oct 23, 2024 •

edited

Loading

codecov bot commented Oct 23, 2024 •

edited

Loading

wslulciuc left a comment

boring-cyborg bot commented Oct 23, 2024

fix: Correct SQL query pagination for DatasetVersion findAll method #2945

fix: Correct SQL query pagination for DatasetVersion findAll method #2945

Conversation

inanalper commented Oct 23, 2024

Problem

Solution

Checklist

boring-cyborg bot commented Oct 23, 2024

netlify bot commented Oct 23, 2024 • edited Loading

✅ Deploy Preview for peppy-sprite-186812 canceled.

codecov bot commented Oct 23, 2024 • edited Loading

Codecov Report

wslulciuc left a comment

Choose a reason for hiding this comment

boring-cyborg bot commented Oct 23, 2024

netlify bot commented Oct 23, 2024 •

edited

Loading

codecov bot commented Oct 23, 2024 •

edited

Loading